Harden character expression transitions - #55
Merged
Conversation
S1mplector
marked this pull request as ready for review
July 28, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
exprDur/expressionDurationsupport to[move]and[character … move …]-1sentinel: omitted expression duration still uses the documented 180 ms default, whileexprDur=0swaps instantlyRoot cause and impact
Movement and expression changes previously shared only the movement command’s timing path, while the expression crossfade duration was hard-coded in state. Save/load and rollback already captured the target expression deterministically, but that contract was not protected by tests.
Authors can now tune movement and expression timing independently without changing existing scripts. Saves and rollback made during a crossfade restore a complete target expression with no renderer-specific half-state.
Validation
./gradlew :core:test --no-daemongit diff --checkCloses #14
Closes #15
Closes #19