Clean semantic log identity and improve text output#184
Closed
VolkerChristian wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
inst=/conn=identity.Description
frameworkLog()messages no longer prependgetSocketConnection()->getConnectionName()and now log the human message text only; changes are insrc/web/http/client/SocketContext.cppandsrc/web/http/server/SocketContext.cpp.{}format arguments from TLS acceptor/connector and connection shutdown messages so object-scopedthis->log()/SocketConnection::log()messages do not passconfig->getInstanceName()/Super::getConnectionName()as leading message text; changes are insrc/core/socket/stream/tls/SocketAcceptor.hpp,src/core/socket/stream/tls/SocketConnector.hpp, andsrc/core/socket/stream/tls/SocketConnection.hpp.SemanticIdentityMessagePolicyTestundertests/unit/log/SemanticIdentityMessagePolicyTest.cppand registered it in the log testCMakeLists.txtto detect obvious duplicated identity prefixes on known object-scoped semantic logger surfaces.docs/logging/semantic-identity-message-cleanup-report.mdthat records the searches performed, files audited, files changed, prefixes removed, intentionally retained occurrences, and follow-up notes about static helper logs.Testing
cmake -S . -B cmake-build -DSNODEC_BUILD_TESTS=ON -DSNODEC_BUILD_APPS=ONandcmake --build cmake-build --parallel 2.ctest --test-dir cmake-build -R "SemanticIdentityMessagePolicyTest|Log|Semantic|Logger" --output-on-failureand then the full test set withctest --test-dir cmake-build --output-on-failure, both completed successfully for the tests that ran in this environment.SemanticIdentityMessagePolicyTestpassed; the full CTest run reported many repository-gated component tests asSkippedper existing test gating but overall the executed tests passed.git diff --check(no whitespace/check failures) and formatted touched files withclang-formatwhere appropriate.Codex Task