Remove duplicated socket and TLS log identity prefixes#189
Merged
VolkerChristian merged 1 commit intoJul 11, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ssl_log()or other static/helper logging patterns.Description
src/core/socket/stream/SocketClient.h,src/core/socket/stream/SocketServer.h,src/core/socket/stream/tls/SocketConnection.hpp,src/core/socket/stream/tls/SocketAcceptor.hpp, andsrc/core/socket/stream/tls/SocketConnector.hpp.getInstanceName()/getConnectionName()placeholders and their function arguments/stream prefixes, preservedssl_log()calls and SNI/config callback logging, and ensured resulting free-text messages start cleanly (e.g. withSSL/TLS:where applicable).Testing
core-socket-stream,core-socket-stream-legacy,core-socket-stream-tls,net-in-stream-legacy,net-in-stream-tls,net-in6-stream-legacy,net-in6-stream-tls,net-un-stream-legacy, andnet-un-stream-tls, and the relevant semantic migration and socket/TLS test executables; builds completed successfully.SemanticLoggerRound2Test,SocketEndpointLogApiRound5Test,SocketConnectionMigration01Test,SocketConnectorAcceptorMigration02Test,SocketServerClientMigration03Test,TlsSocketStreamMigration06Testand related composition tests); the selected tests passed and composition tests were skipped by existing runtime conditions.git diff --checkshowed no whitespace problems andclang-format -iwas applied to all modified C++ files.rgover the five scoped files forgetConnectionName|getInstanceName|connectionNameand for the SSL/TLS logging patterns and inspected remaining results to ensure only expected identity use remains (e.g.,ssl_log(), OpenSSL ex-data, SNI/config callbacks, another-object logging and scope construction).Notes: 23 audited logging call sites inspected, 23 message prefixes removed, 4 lambda captures removed because they became unused; structured
inst=andconn=metadata remain unchanged;ssl_log()and KEEP/other excluded rows were left intact.Codex Task