Skip to content

Remove duplicated socket and TLS log identity prefixes#189

Merged
VolkerChristian merged 1 commit into
masterfrom
codex/remove-duplicated-socket-and-tls-log-identity-prefixes
Jul 11, 2026
Merged

Remove duplicated socket and TLS log identity prefixes#189
VolkerChristian merged 1 commit into
masterfrom
codex/remove-duplicated-socket-and-tls-log-identity-prefixes

Conversation

@VolkerChristian

Copy link
Copy Markdown
Member

Motivation

  • Remove duplicated connection-name or instance-name free-text prefixes from proven object-scoped socket/TLS logger messages identified by the authoritative audit to avoid redundant human-readable output while preserving structured metadata.
  • Preserve logger surface, log levels, control flow, TLS/error behavior and do not change ssl_log() or other static/helper logging patterns.

Description

  • Edited 5 files to remove duplicated formatting placeholders and arguments from 23 audited call sites and to drop 4 lambda captures that became unused as a direct mechanical consequence of those removals: src/core/socket/stream/SocketClient.h, src/core/socket/stream/SocketServer.h, src/core/socket/stream/tls/SocketConnection.hpp, src/core/socket/stream/tls/SocketAcceptor.hpp, and src/core/socket/stream/tls/SocketConnector.hpp.
  • Audit group mapping implemented: CSI-P044, CSI-P048: SocketClient/SocketServer instance prefixes; CSI-P049–CSI-P055: TLS SocketConnection prefixes; CSI-P056, CSI-P058, CSI-P060, CSI-P061: TLS accept-side handshake callback prefixes; CSI-P066, CSI-P068, CSI-P070, CSI-P071: TLS connect-side handshake callback prefixes; CSI-P062–CSI-P064, CSI-P072–CSI-P074: TLS endpoint configuration instance prefixes.
  • Removed only the duplicated getInstanceName() / getConnectionName() placeholders and their function arguments/stream prefixes, preserved ssl_log() calls and SNI/config callback logging, and ensured resulting free-text messages start cleanly (e.g. with SSL/TLS: where applicable).
  • Per the audit rules, no logger surface, formatting, backend, category, level, helper, or architectural logging changes were made.

Testing

  • Built a debug test configuration and compiled the smallest set of targets that exercise the modified files; built targets included core-socket-stream, core-socket-stream-legacy, core-socket-stream-tls, net-in-stream-legacy, net-in-stream-tls, net-in6-stream-legacy, net-in6-stream-tls, net-un-stream-legacy, and net-un-stream-tls, and the relevant semantic migration and socket/TLS test executables; builds completed successfully.
  • Enabled tests and ran selected unit/migration tests (SemanticLoggerRound2Test, SocketEndpointLogApiRound5Test, SocketConnectionMigration01Test, SocketConnectorAcceptorMigration02Test, SocketServerClientMigration03Test, TlsSocketStreamMigration06Test and related composition tests); the selected tests passed and composition tests were skipped by existing runtime conditions.
  • Ran repository checks and formatting: git diff --check showed no whitespace problems and clang-format -i was applied to all modified C++ files.
  • Performed search/manual verification with rg over the five scoped files for getConnectionName|getInstanceName|connectionName and for the SSL/TLS logging patterns and inspected remaining results to ensure only expected identity use remains (e.g., ssl_log(), OpenSSL ex-data, SNI/config callbacks, another-object logging and scope construction).

Notes: 23 audited logging call sites inspected, 23 message prefixes removed, 4 lambda captures removed because they became unused; structured inst= and conn= metadata remain unchanged; ssl_log() and KEEP/other excluded rows were left intact.


Codex Task

@VolkerChristian VolkerChristian merged commit d4e2999 into master Jul 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant