tetrad: Add version 7.6.10#17895
Conversation
📝 WalkthroughWalkthroughThis PR adds Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
the
package-request-needed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
bucket/tetrad.json (1)
1-28: Please run local manifest checks before submission.Use the Scoop maintainer flow for this manifest:
scoop config debug true scoop config gh_token <your-github-token> .\bin\checkver.ps1 -App tetrad -f .\bin\formatjson.ps1 -App tetrad scoop install .\bucket\tetrad.json -a 64bitReference docs:
- Contribution Guide: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- Wiki: https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/tetrad.json` around lines 1 - 28, The manifest tetrad.json must be validated locally using the Scoop maintainer flow; run the Scoop debug/checkver/formatjson/install sequence to regenerate and verify the "hash" and ensure "checkver" and "autoupdate" produce the correct "url", "bin", and "shortcuts" values; if checkver/formatjson updates the version or filename, update the "bin", "shortcuts" and "url" templates in tetrad.json and replace the stale "hash" with the value produced by the local install verification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/tetrad.json`:
- Line 3: The manifest's description field ("description" in tetrad.json) is
missing a linked package-request issue; update the tetrad.json description (or
the PR body) to include the package-request issue reference (either as
"#<number>" or the full issue URL created via the provided template link) so the
new manifest meets the ScoopInstaller/Extras requirement for linked
package-request issues before merge.
- Line 5: Update the manifest's "license" field which currently uses the invalid
SPDX string "GPL V2": replace it with a valid SPDX identifier such as
"GPL-2.0-only" or "GPL-2.0-or-later" to match the upstream licensing terms;
ensure the change is made in the JSON entry for the "license" key so the
manifest validates against Scoop's SPDX requirements.
- Around line 8-14: The manifest runs a JAR directly (fields "bin" and
"shortcuts") but doesn’t declare a runtime suggestion for Java; add a "suggest"
array entry for the standard Scoop Java runtime identifier (e.g., "openjdk" or
the project's preferred Java bucket name) to the JSON manifest so users without
Java get guidance; update the JSON at the same object level as "bin" and
"shortcuts" to include "suggest": ["openjdk"] (or the appropriate Scoop Java
package name).
---
Nitpick comments:
In `@bucket/tetrad.json`:
- Around line 1-28: The manifest tetrad.json must be validated locally using the
Scoop maintainer flow; run the Scoop debug/checkver/formatjson/install sequence
to regenerate and verify the "hash" and ensure "checkver" and "autoupdate"
produce the correct "url", "bin", and "shortcuts" values; if checkver/formatjson
updates the version or filename, update the "bin", "shortcuts" and "url"
templates in tetrad.json and replace the stale "hash" with the value produced by
the local install verification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 788ac237-1fe6-4eb7-9146-cd521285d33e
📒 Files selected for processing (1)
bucket/tetrad.json
| @@ -0,0 +1,28 @@ | |||
| { | |||
| "homepage": "http://www.phil.cmu.edu/tetrad/", | |||
| "description": "Graphical Causal Models", | |||
There was a problem hiding this comment.
New package request issue link is missing for this new manifest.
For a newly added manifest, include a linked package-request issue (#<number> or issue URL) in the manifest description context or PR body before merge.
Create one here: https://github.com/ScoopInstaller/Extras/issues/new?labels=package-request&template=package-request.yml&title=%5BRequest%5D%3A+
As per coding guidelines, new package manifests must include a linked package request issue and meet acceptance criteria.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/tetrad.json` at line 3, The manifest's description field
("description" in tetrad.json) is missing a linked package-request issue; update
the tetrad.json description (or the PR body) to include the package-request
issue reference (either as "#<number>" or the full issue URL created via the
provided template link) so the new manifest meets the ScoopInstaller/Extras
requirement for linked package-request issues before merge.
| "homepage": "http://www.phil.cmu.edu/tetrad/", | ||
| "description": "Graphical Causal Models", | ||
| "version": "7.6.10", | ||
| "license": "GPL V2", |
There was a problem hiding this comment.
Use a valid SPDX license string at Line 5.
"GPL V2" is not a valid SPDX identifier for Scoop manifests. Use an SPDX form like "GPL-2.0-only" or "GPL-2.0-or-later" (based on upstream licensing text).
As per coding guidelines, Scoop manifest metadata should follow standard manifest conventions; and based on learnings, avoid deprecated/bare GNU identifiers and prefer suffixed SPDX variants.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/tetrad.json` at line 5, Update the manifest's "license" field which
currently uses the invalid SPDX string "GPL V2": replace it with a valid SPDX
identifier such as "GPL-2.0-only" or "GPL-2.0-or-later" to match the upstream
licensing terms; ensure the change is made in the JSON entry for the "license"
key so the manifest validates against Scoop's SPDX requirements.
| "bin": "tetrad-gui-7.6.10-launch.jar", | ||
| "shortcuts": [ | ||
| [ | ||
| "tetrad-gui-7.6.10-launch.jar", | ||
| "tetrad-gui" | ||
| ] | ||
| ], |
There was a problem hiding this comment.
Add runtime dependency guidance for Java at Line 8+ (.jar launcher).
This package runs a JAR directly, so users without Java will get runtime failure. Add a suggest entry for the Java runtime (standard Scoop identifier).
Proposed manifest patch
{
"homepage": "http://www.phil.cmu.edu/tetrad/",
"description": "Graphical Causal Models",
"version": "7.6.10",
"license": "GPL V2",
+ "suggest": {
+ "JRE": "java/openjdk"
+ },
"url": "https://s01.oss.sonatype.org/content/repositories/releases/io/github/cmu-phil/tetrad-gui/7.6.10/tetrad-gui-7.6.10-launch.jar",As per coding guidelines, manifests should declare common runtime dependencies (e.g., .NET/VCREDIST/Java) in suggest.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/tetrad.json` around lines 8 - 14, The manifest runs a JAR directly
(fields "bin" and "shortcuts") but doesn’t declare a runtime suggestion for
Java; add a "suggest" array entry for the standard Scoop Java runtime identifier
(e.g., "openjdk" or the project's preferred Java bucket name) to the JSON
manifest so users without Java get guidance; update the JSON at the same object
level as "bin" and "shortcuts" to include "suggest": ["openjdk"] (or the
appropriate Scoop Java package name).
1 participant
Tetrad builds graphical causal models
<manifest-name[@version]|chore>: <general summary of the pull request>