android-performance-analyzer: Add version 0.8.1#17941
Open
Vixb1122 wants to merge 2 commits into
Open
Conversation
📝 WalkthroughWalkthroughThe PR adds a new Scoop package manifest for Android Performance Analyzer version 0.8.0-RC3. The manifest specifies the Windows 64-bit download URL, SHA256 hash, and extraction directory name. It includes a version-check regex pattern to detect updates from the Android IDE zip distribution URL and autoupdate configuration that automatically derives the download URL and extracts the SHA256 hash from the project page. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/android-performance-analyzer.json`:
- Around line 22-33: Run the version detection and autoupdate validation for the
manifest by testing the "checkver" regex and the "autoupdate.hash.regex" against
the Android Performance Analyzer page and ensure the captured "version" group
matches the "autoupdate.architecture.64bit.url" v$version pattern; if the regex
doesn't match, update "checkver" or "autoupdate.hash.regex" to the correct
patterns (or adjust the basename/sha256 anchor) so the filename and SHA256 are
found, then run the manifest formatter/linter and perform a local install test
for 64bit to confirm installation succeeds.
- Around line 1-34: The manifest file bucket/android-performance-analyzer.json
currently uses LF line endings; convert the file to CRLF (\r\n) line endings
before merging. Open bucket/android-performance-analyzer.json (the JSON
containing keys like "version" and "checkver") and change line endings to CRLF
in your editor or run git with core.autocrlf=true, then re-save and commit the
file so the repository stores CRLF line endings. Ensure the committed file shows
CRLF via git ls-files --eol before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 4184da79-4a53-4413-a168-8c844b809543
📒 Files selected for processing (1)
bucket/android-performance-analyzer.json
Comment on lines
+1
to
+34
| { | ||
| "version": "0.8.0-RC3", | ||
| "description": "Optimize your app or game with Android's new profiler and performance analysis tool for the Android ecosystem.", | ||
| "homepage": "https://developer.android.com/android-performance-analyzer", | ||
| "license": { | ||
| "identifier": "Freeware", | ||
| "url": "https://developer.android.com/studio/terms" | ||
| }, | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://dl.google.com/android/apa/ide-zips/v0.8.0-RC3/android-performance-analyzer-windows.zip", | ||
| "hash": "5dd973d9aa8a36895f172935b713ac856f663537e7235037add12b01e6bb4689", | ||
| "shortcuts": [ | ||
| [ | ||
| "bin\\apa64.exe", | ||
| "Android Performance Analyzer" | ||
| ] | ||
| ] | ||
| } | ||
| }, | ||
| "extract_dir": "apa-windows", | ||
| "checkver": "/ide-zips/v(?<version>[\\w.-]+)/android-performance-analyzer-windows.zip", | ||
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://dl.google.com/android/apa/ide-zips/v$version/android-performance-analyzer-windows.zip", | ||
| "hash": { | ||
| "url": "https://developer.android.com/android-performance-analyzer", | ||
| "regex": "(?sm)$basename.*?$sha256" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win
Ensure the manifest uses CRLF line endings.
Scoop manifests must use CRLF (\r\n) line endings, not LF (\n). Please verify that this file uses CRLF line endings before merging.
You can check and convert line endings in your editor or using Git:
# Check current line endings
git ls-files --eol bucket/android-performance-analyzer.json
# Ensure CRLF on checkout (if needed)
git config core.autocrlf trueSee the Contribution Guide for more details.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/android-performance-analyzer.json` around lines 1 - 34, The manifest
file bucket/android-performance-analyzer.json currently uses LF line endings;
convert the file to CRLF (\r\n) line endings before merging. Open
bucket/android-performance-analyzer.json (the JSON containing keys like
"version" and "checkver") and change line endings to CRLF in your editor or run
git with core.autocrlf=true, then re-save and commit the file so the repository
stores CRLF line endings. Ensure the committed file shows CRLF via git ls-files
--eol before merging.
Comment on lines
+22
to
+33
| "checkver": "/ide-zips/v(?<version>[\\w.-]+)/android-performance-analyzer-windows.zip", | ||
| "autoupdate": { | ||
| "architecture": { | ||
| "64bit": { | ||
| "url": "https://dl.google.com/android/apa/ide-zips/v$version/android-performance-analyzer-windows.zip", | ||
| "hash": { | ||
| "url": "https://developer.android.com/android-performance-analyzer", | ||
| "regex": "(?sm)$basename.*?$sha256" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major | ⚡ Quick win
Verify checkver and autoupdate configuration, then test locally.
The checkver regex and autoupdate configuration look reasonable, but should be tested to ensure they work correctly:
- The
checkverpattern searches for version strings in the URL structure. - The
autoupdate.hash.regexassumes the homepage contains the filename followed by the SHA256 hash.
Please test the manifest locally using the following commands:
# Optional: Enable debug mode and set GitHub token (read access only for GitHub API)
scoop config debug true
scoop config gh_token <your-github-token>
# Force version detection and autoupdate
.\bin\checkver.ps1 -App android-performance-analyzer -f
# Auto-format (Lint) the JSON manifest
.\bin\formatjson.ps1 -App android-performance-analyzer
# Test installation for 64-bit architecture
scoop install bucket\android-performance-analyzer.json -a 64bitSee the Contribution Guide and App Manifests wiki for more details.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/android-performance-analyzer.json` around lines 22 - 33, Run the
version detection and autoupdate validation for the manifest by testing the
"checkver" regex and the "autoupdate.hash.regex" against the Android Performance
Analyzer page and ensure the captured "version" group matches the
"autoupdate.architecture.64bit.url" v$version pattern; if the regex doesn't
match, update "checkver" or "autoupdate.hash.regex" to the correct patterns (or
adjust the basename/sha256 anchor) so the filename and SHA256 are found, then
run the manifest formatter/linter and perform a local install test for 64bit to
confirm installation succeeds.
arvdk
added a commit
to arvdk/Extras
that referenced
this pull request
Jun 9, 2026
Vixb1122
changed the title
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. android-performance-analyzer
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17856
<manifest-name[@version]|chore>: <general summary of the pull request>