bulk-crap-uninstaller: Update GitHub repo URLs#18011
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates the Bulk Crap Uninstaller Scoop package manifest in a single JSON file. The changes restructure the license field from a string to an object containing identifier and URL, migrate the 64-bit portable download source and hash from the Klocman repo to BCUninstaller, simplify pre_install, convert uninstaller.script into a step array that preserves settings, switch checkver to the BCUninstaller GitHub Releases "latest" endpoint with regex extraction, and update the autoupdate 64-bit URL template. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bucket/bulk-crap-uninstaller.json (1)
48-51:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winHash algorithm mismatch will break autoupdate.
The current manifest uses a SHA-256 hash (line 12, 64 hex characters), but the
autoupdate.hashblock is configured to extract SHA-1 from SourceForge. Future automated updates will fail or use the wrong hash type.Recommended fix: Remove the
hashblock entirely. Per Scoop's autoupdate behavior, whencheckveruses GitHub and no explicit hash configuration is provided, Scoop will obtain the hash from the GitHub Releases API or compute it locally by downloading the file. This approach:
- Aligns with your PR goal to obtain hashes from GitHub
- Ensures SHA-256 is used automatically
- Simplifies the manifest
Alternatively, if the BCUninstaller releases include a separate SHA-256 checksum file asset, you can point
autoupdate.hash.urlto that file instead.🔧 Proposed fix: remove the hash block
"autoupdate": { "architecture": { "64bit": { "url": "https://github.com/BCUninstaller/Bulk-Crap-Uninstaller/releases/download/v$matchTag/BCUninstaller_$version_portable.zip" } - }, - "hash": { - "url": "https://sourceforge.net/projects/bulk-crap-uninstaller/files/v$matchTag/", - "regex": "$basename.*?\"sha1\":\"$sha1" } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/bulk-crap-uninstaller.json` around lines 48 - 51, The autoupdate.hash block currently extracts a SHA-1 from SourceForge which conflicts with the manifest's SHA-256 checksum and will break autoupdate; remove the entire "hash" block (the autoupdate.hash configuration) from the manifest so Scoop will derive/verify SHA-256 automatically based on the existing checkver (GitHub releases), or if BCUninstaller provides a SHA-256 checksum asset instead, replace autoupdate.hash with a URL pointing to that SHA-256 file so autoupdate extracts the correct SHA-256 value.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@bucket/bulk-crap-uninstaller.json`:
- Around line 48-51: The autoupdate.hash block currently extracts a SHA-1 from
SourceForge which conflicts with the manifest's SHA-256 checksum and will break
autoupdate; remove the entire "hash" block (the autoupdate.hash configuration)
from the manifest so Scoop will derive/verify SHA-256 automatically based on the
existing checkver (GitHub releases), or if BCUninstaller provides a SHA-256
checksum asset instead, replace autoupdate.hash with a URL pointing to that
SHA-256 file so autoupdate extracts the correct SHA-256 value.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 88fb3ab4-d34f-4a66-9df8-9c64adfe4e28
📒 Files selected for processing (1)
bucket/bulk-crap-uninstaller.json
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
z-Fng
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. bulk-crap-uninstaller
|
z-Fng
left a comment
z-Fng
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
2 participants
Change exists since v6.2.0 (per changelog)
<manifest-name[@version]|chore>: <general summary of the pull request>