fix(install): accept pi3-64 in Ansible playbook validation#3067
Merged
Conversation
A Raspberry Pi 3 running a 64-bit OS reports DEVICE_TYPE=pi3-64 (both bin/install.sh::set_device_type and bin/upgrade_containers.sh emit it, and latest-pi3-64 Docker images are built), but the Ansible playbook never accepted that value: - ansible/site.yml's pre_task assertion only allowed pi2, pi3, pi4-64, pi5, x86, arm64 — so a 64-bit Pi 3 install aborted at "Gathering Facts" with "Required environment variables missing or invalid" (forums.screenly.io/t/6716). - ansible/roles/system/tasks/docker.yml's docker_arch_by_device_type map is exhaustive-by-design and would have raised on the unmapped pi3-64 key; add the arm64 mapping. - the device_is_pi membership test omitted pi3-64, which would have dropped the gpio group on a board that is a Pi. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
There was a problem hiding this comment.
Pull request overview
This PR fixes Anthias installation on Raspberry Pi 3 devices running a 64-bit OS by aligning Ansible’s validation and device-type mappings with the already-supported DEVICE_TYPE=pi3-64 value used elsewhere in the project.
Changes:
- Allow
pi3-64inansible/site.ymlpre-task validation and error message. - Map
pi3-64toarm64in Docker dpkg-arch selection (docker_arch_by_device_type). - Treat
pi3-64as a Raspberry Pi for Pi-specific group membership logic (device_is_pi).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ansible/site.yml | Extends DEVICE_TYPE allowlist and updates assertion failure message to include pi3-64. |
| ansible/roles/system/tasks/docker.yml | Adds pi3-64→arm64 mapping and includes pi3-64 in Pi-detection list for group assignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
A user reported that installing Anthias v2026.6.3 on a Raspberry Pi 3 B+ stops halfway with:
The install aborts at the Ansible playbook's first pre-task (right after "Gathering Facts"), before any real work runs. Reported at forums.screenly.io/t/anthias-v2026-6-3-installation-stops-halfway-on-pi3-b/6716.
Root cause
A Pi 3 on a 64-bit OS is detected as
DEVICE_TYPE=pi3-64. Bothbin/install.sh::set_device_typeandbin/upgrade_containers.shcorrectly emitpi3-64, the docker-build workflow publisheslatest-pi3-64images, and the viewer/processing code all handlepi3-64. But the Ansible side was never updated to accept it:ansible/site.yml— thepre_tasksvalidation assertion only allowedpi2, pi3, pi4-64, pi5, x86, arm64. A 64-bit Pi 3 fails this assertion immediately. This is the exact error the user hit.ansible/roles/system/tasks/docker.yml—docker_arch_by_device_typeis exhaustive-by-design (raises on an unmapped key).pi3-64had no entry, so even past the assertion it would have crashed resolving the dpkg architecture. Addedpi3-64: arm64.ansible/roles/system/tasks/docker.yml—device_is_piomittedpi3-64, which would have dropped thegpiogroup on a board that is in fact a Pi.A 32-bit-OS Pi 3 (
pi3) was unaffected, which is why this slipped through.Fix
Add
pi3-64to all three lists. No behavioural change for any other board.Testing
python3 -c "import yaml; ..."parses both edited YAML files cleanly.pi3-64is the value emitted byset_device_type/upgrade_containers.shon aarch64 Pi 3 and thatlatest-pi3-64images are produced by the docker-build workflow, so the rendered compose image tag (anthias-server:latest-pi3-64) resolves.E2E
Not run on hardware (no 64-bit Pi 3 testbed in the loop). The change is a validation-list addition on a code path already exercised by every other board.
🤖 Generated with Claude Code