You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Picking this up from the Signal K server side — these meteo/environment units are exactly what's missing in practice today.
Context: a user reported environment metadata (e.g. environment.water.level → {units: "m"}) disappearing in 2.28.0-beta. The root cause was a server-side regression (now fixed in SignalK/signalk-server#2744 + #2742), but it surfaced because FreeboardSK injects ~18 of these weather units at runtime as a workaround — precisely because they aren't in the base. Its plugin even carries a @todo remove after merge of specification#662. So this PR stalling has a concrete downstream cost.
The 18 paths currently relying on that runtime workaround (units the base has no definition for):
One open question for @tkurki: on the server thread you've indicated @signalk/path-metadata should be the master for well-known paths and units going forward (moving away from the JSON-schema-defined full tree). If that's the direction, should these meteo units land in @signalk/path-metadata (which this PR could mirror), or stay authored here in environment.json with path-metadata derived from it? Happy to help wire whichever way you prefer — once the units are in the base, FreeboardSK can drop its runtime workaround entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to add paths to the
environmentgroup that relate to the processing of AIS weather messages.By defining the additional attibutes and metadata clients will have available weather station observation and forecast values with the correct units.