[pull] master from dotansimha:master - #1112
Merged
Merged
Conversation
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix: run the windows-latest CI legs on Windows The test and test-watcher jobs define an os matrix axis with a single windows-latest include entry, but that leg has never run on Windows: - the include entry uses the key node-version while the axis is node_version, so the windows combination is created with an empty matrix.node_version; - runs-on is hardcoded to ubuntu-latest, so the leg executes on Ubuntu with the runner's default Node. Consume matrix.os in runs-on and fix the include key so the windows leg runs on a Windows runner with the pinned Node version. Add a workflow matrix check (run in CI) that validates every workflow file, so this class of silent misconfiguration fails the build instead of degrading the matrix. * Remove workflows check --------- Co-authored-by: Eddy Nguyen <ch@eddeee888.me>
…escriptions` (#10909) * Add types and tests for TypeScript operations plugin option `disableDescriptions` * Add a changeset. --------- Co-authored-by: Eddy Nguyen <ch@eddeee888.me>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )