Skip to content

RPS-10166 Job strings#111

Merged
az-smartling merged 6 commits into
masterfrom
RPS-10166_Job_strings
Jun 5, 2026
Merged

RPS-10166 Job strings#111
az-smartling merged 6 commits into
masterfrom
RPS-10166_Job_strings

Conversation

@az-smartling
Copy link
Copy Markdown
Contributor

Manage the strings on a translation job from the CLI.

Usage

jobs strings add    <jobUidOrName> --hashcode H [--hashcode H …] [--target-locale L …] [--move-enabled]
jobs strings remove <jobUidOrName> --hashcode H [--hashcode H …] [--locale L …]
jobs strings list   <jobUidOrName> [--target-locale L] [--limit N] [--offset N]
  • Accepts a job UID or name (resolved via the shared jobresolver); project from --project/config.
  • add/remove report the API's successCount/failCount; when nothing is affected (e.g. bad hashcodes) the output says 0 succeeded with a hint to verify the hashcodes exist.
  • list renders a TARGET LOCALE ID/HASHCODE table and shows Showing N of <totalCount>; --output simple|json|table.

Smartling/api-sdk-go#35

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new set of CLI commands under smartling-cli jobs strings to add, remove, and list strings on translation jobs, complete with service logic, tests, and documentation. Feedback on the changes suggests initializing the Items slice in ListOutput with make to ensure it marshals to an empty JSON array [] instead of null when empty. Additionally, it is recommended to mark the --hashcode flag as required in Cobra for both the add and remove commands to enable early validation during CLI parsing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread services/jobs/strings/run_list.go Outdated
Comment thread cmd/jobs/strings/add/cmd_add.go
Comment thread cmd/jobs/strings/remove/cmd_remove.go
@az-smartling az-smartling requested review from dimitrystd and junky June 5, 2026 06:54
@az-smartling az-smartling merged commit af59d0d into master Jun 5, 2026
@az-smartling az-smartling deleted the RPS-10166_Job_strings branch June 5, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants