Fix per-feature OOV index shift in FeatureEmbeddingLayer#613
Draft
mkolodner-sc wants to merge 1 commit intomainfrom
Draft
Fix per-feature OOV index shift in FeatureEmbeddingLayer#613mkolodner-sc wants to merge 1 commit intomainfrom
mkolodner-sc wants to merge 1 commit intomainfrom
Conversation
Replace the global __plus_one flag with a per-feature __feature_plus_one dict so that the +1 index shift is only applied to features with a single OOV bucket (int_domain.min == -1). With multiple OOV buckets, TFT assigns OOV indices starting at vocab_size (min == 0), so applying +1 would push the max OOV index out of bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the global __plus_one flag with a per-feature __feature_plus_one dict so that the +1 index shift is only applied to features with a single OOV bucket (int_domain.min == -1). With multiple OOV buckets, TFT assigns OOV indices starting at vocab_size (min == 0), so applying +1 would push the max OOV index out of bounds.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO