feat: Refresh DoodleUI typography foundation BED-9082 - #3067
Draft
justin-prime1 wants to merge 2 commits into
Draft
feat: Refresh DoodleUI typography foundation BED-9082#3067justin-prime1 wants to merge 2 commits into
justin-prime1 wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe doodle-ui typography system now uses Figtree and Nunito Sans, updated Tailwind tokens and variant mappings, shared typography styles in Card and Dialog, expanded Storybook examples, and corresponding tests and documentation. ChangesTypography visual language refresh
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
coderabbitai
Bot
added
enhancement
justin-prime1
marked this pull request as draft
July 28, 2026 23:58
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/javascript/doodle-ui/README.md`:
- Around line 76-87: Update the two fenced code blocks in the README: tag the
dependency installation block with sh and the font import block with tsx (or
ts), preserving their contents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1ab2b2a2-2a94-4ad1-b4e4-c6f769076de6
⛔ Files ignored due to path filters (4)
.yarn/cache/@fontsource-figtree-npm-5.3.0-b25258c461-d1899a45cb.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fontsource-nunito-sans-npm-5.3.0-dc8ab0f7ed-4ffde59fb0.zipis excluded by!**/.yarn/**,!**/*.zip.yarn/cache/@fontsource-roboto-npm-5.2.10-7b0c25dd7f-2fc9e9db66.zipis excluded by!**/.yarn/**,!**/*.zipyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (15)
packages/javascript/doodle-ui/.storybook/preview.tsxpackages/javascript/doodle-ui/README.mdpackages/javascript/doodle-ui/package.jsonpackages/javascript/doodle-ui/src/components/Card/Card.test.tsxpackages/javascript/doodle-ui/src/components/Card/Card.tsxpackages/javascript/doodle-ui/src/components/DataTable/DataTable.stories.tsxpackages/javascript/doodle-ui/src/components/DataTable/StorybookExample/ExampleDataTable.tsxpackages/javascript/doodle-ui/src/components/Dialog/Dialog.test.tsxpackages/javascript/doodle-ui/src/components/Dialog/Dialog.tsxpackages/javascript/doodle-ui/src/components/Typography/Typography.stories.tsxpackages/javascript/doodle-ui/src/components/Typography/Typography.test.tsxpackages/javascript/doodle-ui/src/components/Typography/Typography.tsxpackages/javascript/doodle-ui/src/tailwind/plugin.tspackages/javascript/doodle-ui/src/tailwind/preset.tspackages/javascript/doodle-ui/src/tailwind/typography.test.ts
Comment on lines
76
to
87
| ``` | ||
| yarn add @fontsource/roboto | ||
| yarn add @fontsource/figtree @fontsource/nunito-sans | ||
| ``` | ||
|
|
||
| Then import the font in your entrypoint: | ||
| Then import the required weights in your entrypoint: | ||
|
|
||
| ``` | ||
| import '@fontsource/roboto/400.css'; | ||
| import '@fontsource/figtree/400.css'; | ||
| import '@fontsource/figtree/500.css'; | ||
| import '@fontsource/nunito-sans/600.css'; | ||
| import '@fontsource/nunito-sans/700.css'; | ||
| ``` |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add language tags to the new fenced code blocks.
The two new fences trigger markdownlint MD040. Use sh for the installation block and tsx (or ts) for the import block.
Proposed fix
-```
+```sh
yarn add `@fontsource/figtree` `@fontsource/nunito-sans`Then import the required weights in your entrypoint:
- +tsx
import '@fontsource/figtree/400.css';
</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.23.1)
[warning] 76-76: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
[warning] 82-82: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/javascript/doodle-ui/README.md` around lines 76 - 87, Update the two
fenced code blocks in the README: tag the dependency installation block with sh
and the font import block with tsx (or ts), preserving their contents.
Source: Linters/SAST tools
TheNando
force-pushed
the
feature/doodleui-typography-foundation
branch
from
August 18, 2026 17:23
d18c4cd to
80b0f9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira
BED-9082: Update typography foundations in DoodleUI
Validation
just prepare-for-codereviewNotes
Summary by CodeRabbit
New Features
text-mutedas an alias for the existing light text color.Bug Fixes
Documentation