feat: Display Associated Labels in Explore Entity Panel BED-9168 - #3102
Open
justin-prime1 wants to merge 1 commit into
Open
feat: Display Associated Labels in Explore Entity Panel BED-9168#3102justin-prime1 wants to merge 1 commit into
justin-prime1 wants to merge 1 commit into
Conversation
Contributor
📝 WalkthroughWalkthroughThe change extracts matching custom label names from asset-group tags and displays them in entity information fields. Tests cover label filtering and entity rendering while excluding zone, owned, unrelated, and unassociated tags. ChangesEntity label display
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/javascript/bh-shared-ui/src/views/Explore/BasicObjectInfoFields.tsx`:
- Around line 80-87: Update the fieldValues construction in
BasicObjectInfoFields so labels is undefined when the labels array is empty,
while preserving the joined label string for non-empty arrays. Keep the existing
field rendering guard unchanged so the Labels row is omitted when no labels
exist.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 3fb6be4d-be54-4f57-ba0f-bd62f19bdeb5
📒 Files selected for processing (5)
packages/javascript/bh-shared-ui/src/components/EntityInfo/EntityInfoContent.test.tsxpackages/javascript/bh-shared-ui/src/components/EntityInfo/EntityObjectInformation.tsxpackages/javascript/bh-shared-ui/src/hooks/useAssetGroupTags/useAssetGroupTags.test.tsxpackages/javascript/bh-shared-ui/src/hooks/useAssetGroupTags/useAssetGroupTags.tsxpackages/javascript/bh-shared-ui/src/views/Explore/BasicObjectInfoFields.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Displays every custom label associated with the selected entity in Explore's Object Information panel.
The shared UI derives associated label-type asset-group tags from the selected node's kinds, excludes zone, ownership, and unrelated tags, and renders multiple labels comma-separated on one row with natural wrapping when horizontal space is unavailable.
Review size: 23 production-code additions and 3 deletions, plus 63 test additions and 1 test deletion.
Motivation and Context
Resolves BED-9168
Analysts currently cannot see an entity's associated custom labels from the Explore entity panel. They must leave their investigation context or use another workflow to determine how the entity has been categorized.
Displaying the labels alongside the existing object information makes this context immediately available without changing the underlying label or asset-group behavior.
How Has This Been Tested?
Environment:
Automated validation:
just prepare-for-codereviewManual browser validation:
Screenshots (optional):
Explore context
Entity panel
Types of changes
Checklist: