Reporting correct compressed/uncompressed file sizes for zip64#654
Closed
ls-urs-keller wants to merge 1 commit into
Closed
Reporting correct compressed/uncompressed file sizes for zip64#654ls-urs-keller wants to merge 1 commit into
ls-urs-keller wants to merge 1 commit into
Conversation
|
I would suggest to fix readInt (with * 256) instead of introducing a new function readLong. JavaScript makes no difference at all (as far as I understand there is no integral number representation). And I would REALLY like this push request to be merged into the package! Actually ist starts crashing at 2GB! See #777. Although I start wondering if jszip is still maintained at all. |
XljBear
approved these changes
Jan 4, 2022
Author
|
Closing in favor of #791 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm stream-uncompressing files around 1.6GB compressed, 11 GB uncompressed.
The file size is incorrectly read from zip64 file entry.
Everything works fine until at the very end when reading the stream it compares uncompressed size with the size actually read and throws an exception.
The left shift operator
<<seems to be the culprit e.g.:10<<8<<8<<8<<8 = 0
whereas
10256256256256 = 42949672960