Skip to content

Install System.Memory to fix msbuild update issue#173

Open
JackGilmore wants to merge 1 commit into
T4MVC:developfrom
JackGilmore:develop
Open

Install System.Memory to fix msbuild update issue#173
JackGilmore wants to merge 1 commit into
T4MVC:developfrom
JackGilmore:develop

Conversation

@JackGilmore

Copy link
Copy Markdown

Resolves #172 issues that are breaking R4MVC after the latest Visual Studio update (17.3.3)

@JackGilmore

Copy link
Copy Markdown
Author

@artiomchi @kevinkuszyk Could either of you review and approve this PR please? This bug is currently causing R4MVC not to work on the latest version of Visual Studio 2022.

@valeriob

Copy link
Copy Markdown
Contributor

Thank you @JackGilmore , pls @artiomchi could you provide a new version ?

@valeriob

Copy link
Copy Markdown
Contributor

Gentle ping @artiomchi :D

@valeriob

valeriob commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

While people wait for it I can provide the nuget package with this change, see the link.
https://1drv.ms/u/s!AqvjZP1RsulxrOo-h4HLVNPMhNNVIw?e=mYjHgs

@jkatsiotis

Copy link
Copy Markdown

Solving this would be a great help for us as well. When possible please accept the PR. Thanks

@valeriob

valeriob commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

I get "install-package : Object reference not set to an instance of an object" when trying to install the package from the nupkg file. Is something wrong?

Hi, we installed via a local server and works fine, if you provide more details on what you are doing maybe I can help you.

@hj-w

hj-w commented Sep 9, 2022

Copy link
Copy Markdown

The .nupkg file from jkatsiotis works! I've added this file as a new package source in package manager settings.

@valeriob

valeriob commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Hi @artiomchi or @kevinkuszyk, can you guys take a look at this and release a new package ? it looks like to work fine.
Thanks

@JackGilmore

Copy link
Copy Markdown
Author

I have sent an email to @artiomchi using the email address on his GitHub profile. Hopefully he picks it up soon and can approve the review 🤞

@valeriob

valeriob commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Gentle ping @artiomchi

@jkatsiotis

Copy link
Copy Markdown

For anyone interested I have uploaded the following on Nuget until (and if) the owners update.

https://www.nuget.org/packages/R4Mvc.Tools.VS2022/

I think I'm giving all relevant credits in the package. Once the official is updated I'll remove that one

@JackGilmore

Copy link
Copy Markdown
Author

Gentle ping @artiomchi / @kevinkuszyk

1 similar comment
@valeriob

Copy link
Copy Markdown
Contributor

Gentle ping @artiomchi / @kevinkuszyk

@JackGilmore

Copy link
Copy Markdown
Author

Gentle nudge @artiomchi @kevinkuszyk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error When Generate R4MVC

4 participants