fix(gh-999): align header logo markup with settings path#1184
Merged
wesleyboar merged 4 commits intoJun 17, 2026
Merged
Conversation
Apply navbar-brand at HeaderLogoPlugin render; align settings fallback template. Pairs with Core-Styles header logo styling.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This was referenced Jun 16, 2026
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Jun 16, 2026
…efault height (#648) ## Overview Fixed logo sizing in `.s-header`: container can now grow for logos with explicit heights, and un-sized logos get a definite default so SVGs don't overflow and PNGs don't balloon. ## Related - required by TACC/Core-CMS#1184 ## Changes - **replaced** `height` with `min-height` on `.navbar-brand` - **added** `--logo-default-height` custom property and `:where(img:not([height]))` rule - **deleted** `.portal-logo` styles and `class="portal-logo"` from demo ## Testing 1. `npm run build:css` 2. `npm start` 3. Open the s-header demo and verify logo sizing with both the SVG and raster variants ## UI https://github.com/user-attachments/assets/891e4fef-04ed-4fda-9c20-fad12ad26bf3 https://github.com/user-attachments/assets/9ea90455-f3f4-4d5c-a443-4211d8413bdb https://github.com/user-attachments/assets/3c9a989a-19a6-4f90-83ee-5018ba899e86
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Jun 16, 2026
) ## Overview Moved the fixed `flex-basis: 175px` and `flex-shrink: 0` from `.navbar-brand` to `.portal-logo`-specific selector, so CMS-only portals needn't suffer the extra space. ## Related - required by TACC/Core-CMS#1184 ## Changes - **moved** styles to new selector ## Testing 1. `npm run build:css` 2. `npm start` 3. Open the s-header demo to verify logo and nav link alignment. 4. Portal logos should have minimum width of 175px. ## UI <img width="900" height="470" alt="added as Portal Logo distinction" src="https://github.com/user-attachments/assets/9dcc07d1-382a-49ef-8381-aaa8e7ca7369" />
Register Portal logo template and picture_attributes_img on default picture; default Header logo to portal_logo with mr-5 on link attributes.
…efault attributes - Added conditional logic to set the template based on the PORTAL_IS_TACC_CORE_PORTAL setting. - Removed the default 'mr-5' class from the attributes in the HeaderLogoForm. - Updated the body class in base.html to remove the conditional portal class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Header logo plugin and settings fallback match Core-Portal link/img classes. Portal logo picture template puts
portal-logoon the image (even if a link is set).Related
Changes
picture_attributes_imgon default Picture@tacc/core-stylesdev dep (temporary pin)Testing
header-content: settings logo usesnavbar-brandon<a>,portal-logoon<img>.PORTAL_IS_TACC_CORE_PORTAL: add Header logo defaults to Portal logo; published output hasportal-logoon<img>andnavbar-brandon the link./cms/header/logo/markup/matches site logo for plugin vs settings paths.UI
Add.a.logo.mov
the.Portal.logo.template.adds.portal-logo.class.mov
add.class.to.Picture.navbar-brand.is.always.present.mov
add.other.attribtues.to.Picture.still.works.and.migrates.to.container.mov
Notes
Bumped
@tacc/core-stylesto a published version after Core-Styles PRs merge.