fix: GH-1185 header logo portal-logo on img-only pictures#1186
Merged
wesleyboar merged 1 commit intoJun 18, 2026
Merged
Conversation
HeaderLogoPlugin mirrors picture template hoist rules so portal-logo lands on img with a single class attribute when attrs are not hoisted, and via picture_img_class when they are. Closes #1185
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes missing
portal-logoon the header logo<img>when the picture has no link, by aligning class placement with the TACC picture template’s attribute hoisting rules.Related
Changes
apply_header_logo_classes()onHeaderLogoPluginto mirror picture template hoist behaviorpicture_img_classon the default picture template for img-only classes when attributes hoist to a parentportal_logopicture template to extend default only (logic lives in the plugin)Testing
docker exec core_cms python manage.py test taccsite_cms.tests.djangocms_picture_portal_logo taccsite_cms.tests.djangocms_picture_default_caption --no-inputmain: add a header logo via CMS, confirm linked logo still hasnavbar-brandon<a>andportal-logoon<img>.<img>still hasportal-logo(and Core-Styles layout holds).UI
Screenshots: pending upload
Notes
Do not merge until #1083 is merged (this PR is stacked on that branch). Rebase onto
mainafter #1083 lands.