refactor(gh-999): simplify header logo rendering#1189
Merged
wesleyboar merged 8 commits intoJun 19, 2026
Merged
Conversation
Use header_logo.html for nav and markup URL; drop ContentRenderer helper, placeholder constant export, and footer sidebar naming (see #1188). Restore id="header-logo" on settings fallback.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…-999-simplify-header-logo
Keep author text where still accurate; only add status row for shared header_logo.html after refactor.
wesleyboar
commented
Jun 18, 2026
wesleyboar
left a comment
wesleyboar
left a comment
Member
Author
There was a problem hiding this comment.
Checking AI's work.
Restore main header_logo.html for settings fallback and markup URL; drop header_logo_via_settings.html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Stacks on #1083. Drops the extra ContentRenderer path and duplicate settings template;
header.htmlowns the static placeholder,header_logo.htmlstays settings markup as onmain.Related
main)main)Changes
render.py,constants.py,header_tags, andheader_logo_via_settings.htmlheader.html:{% static_placeholder "header-logo" or %}→header_logo.htmlCMS_PLACEHOLDER_CONFforheader-logo(keepsfooter-contentwith chore(cms): label footer-content in Structure sidebar #1188)docs/gh-999-editable-header-plan.md(minimal deltas)Testing
Same as #1083 steps 1–4 after this branch is merged into
feat/GH-999-let-cms-admin-edit-header.UI
No new UI; structure only.