chore: add pyproject.toml files for python extensions#2197
Conversation
Review:
|
|
Across the 94 added pyproject.toml files:
What “tighter” means here:
Example:
There:
Identical examples include:
|
d3181fa to
d633d6d
Compare
Review:
|
d633d6d to
9020c46
Compare
Review:
|
9020c46 to
dfed369
Compare
|
Reviewed this PR — it adds 80+ pyproject.toml files, declares dependencies, bumps manifest versions, and normalizes formatting. Overall the change is mechanical and low-risk, but a few things are worth addressing. Summary
Main concern: pyproject.toml is declarative only, not consumed by the build The dependency installer (ai_agents/agents/scripts/install_deps_and_build.sh) only reads requirements.txt — it loops over each extension and runs pip install -r requirements.txt. Nothing in the build path reads pyproject.toml. That has two consequences:
Possible gap: aws_asr_python has no requirements.txt change aws_asr_python ships a pyproject.toml and a manifest bump but, unlike its peers, no requirements.txt change appears in the diff. Its existing requirements.txt contains pytest==8.3.4 mixed with runtime deps, while the new pyproject (amazon-transcribe, pydantic, typing-extensions) omits pytest. If anything later switches to pyproject-based installs, the test-dep handling differs from the rest. Please confirm this extension was handled the same way as the others. Minor
Test coverage No tests added or changed. Reasonable for packaging metadata, but since pyproject.toml is not validated by CI, nothing guards against the drift described above. A lightweight CI check that pyproject.toml dependencies are a superset of (or equal to) requirements.txt runtime deps would catch future divergence. Verdict The packaging metadata itself is well-formed and the change is reversible. The blocking question before merge is intent: are these pyproject.toml files meant to become the install source (in which case the build script and the numpy/pydantic conflicts need resolving), or are they documentation only (in which case it is worth saying so and ideally auto-syncing them with requirements.txt to prevent drift)? |
dfed369 to
170a3e6
Compare
Add project metadata and dependency declarations for the Python extension packages under ai_agents/agents/ten_packages/extension. Bump each extension manifest version to publish the packaging metadata updates.
170a3e6 to
03ccfaf
Compare
Review:
|
Add project metadata and dependency declarations for the Python extension packages under ai_agents/agents/ten_packages/extension.
Bump each extension manifest version to publish the packaging metadata updates.