Fix #535: add visual padding below measurement-order arrow#559
Open
thierry-martinez wants to merge 4 commits into
Open
Fix #535: add visual padding below measurement-order arrow#559thierry-martinez wants to merge 4 commits into
thierry-martinez wants to merge 4 commits into
Conversation
This commit adds padding beneath the measurement-order arrow when visualizing open graphs with layers, fixing TeamGraphix#535 by keeping both the arrow and its label inside the visualization box. This commit simplifies the approach taken in TeamGraphix#536. We reuse the fact that the coordinate transformation employed in `_draw_layers` depends on the current plot limits set on the figure. In this commit, we use `mpl` to track regression for TeamGraphix#535. Because changing the coordinate‑transformation logic in _draw_layers affects other tests (independent of the padding itself), all baseline files have been updated accordingly. This commit only fixes the bug reported in TeamGraphix#535. It does not prevent other objects, such as flow arrows or the legend box, from appearing outside the visualisation frame.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 90.58% 90.59%
=======================================
Files 49 49
Lines 7481 7483 +2
=======================================
+ Hits 6777 6779 +2
Misses 704 704 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds padding beneath the measurement-order arrow when visualizing open graphs with layers, fixing #535 by keeping both the arrow and its label inside the visualization box.
This commit simplifies the approach taken in #536. We reuse the fact that the coordinate transformation employed in
_draw_layersdepends on the current plot limits set on the figure.In this commit, we use
mplto track regression for #535. Because changing the coordinate‑transformation logic in_draw_layersaffects other tests (independent of the padding itself), all baseline files have been updated accordingly.This commit only fixes the bug reported in #535. It does not prevent other objects, such as flow arrows or the legend box, from appearing outside the visualization frame.