Add hash-aware insertion functions with a precalculated hash#94
Merged
Conversation
The `precalculated_hash` overloads currently exist only on the const lookup functions and `erase`; none of the insertion functions can accept a caller-provided hash. This commit adds `try_emplace_hash()`, `insert_or_assign_hash()` and `insert_hash()` to `robin_map`, and `insert_hash()` to `robin_set`.
Owner
|
Thank you for the PR. Yes, I hesitated before to add such functionality as it carries quite a bit of risk of miss use if the wrong hash is provided. But I think it should be alright to add the functionality with enough warning about the potential undefined behaviour in the documentation. Though I would prefer the name |
Contributor
Author
|
@Tessil thanks—I renamed them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
precalculated_hashoverloads currently exist only on the const lookup functions anderase; none of the insertion functions can accept a caller-provided hash. This commit addstry_emplace_hash(),insert_or_assign_hash()andinsert_hash()torobin_map, andinsert_hash()torobin_set.(For context, I am developing a project where the possibility to avoid redundant hash computations leads to a pretty significant speedup when using
tsl::robin_map).