Feat/ts tools#130
Merged
luarss merged 44 commits intoJun 30, 2026
Merged
Conversation
Collaborator
Author
kartikloops
force-pushed
the
feat/ts-tools
branch
from
ea30af4 to
23b020b
Compare
Collaborator
|
@kartikloops Please rebase when you can |
…xecution from python
…ave the pty marked alive
…ent double kill and stale exit codes
…r is not discarded
…pe sequences is not reinterpreted
…rtup failure cannot leave a creating zombie
… creates are not lost
…lock all creation
…annot be bypassed via catch/if/foreach or set x [exec ls]
…ion is not leaked
…ches in TerminateSessionTool
…ot silently dropped
…te-transition side effect
… the dead session from the map
…flect post-loop state
…eady empties the map
…s not retried with SIGTERM
… does not produce a silent 256x256 output
… commands are not exempt
kartikloops
force-pushed
the
feat/ts-tools
branch
from
0e27dec to
461407a
Compare
Collaborator
Author
|
@luarss re-based, please have a look |
luarss
requested changes
Jun 26, 2026
… } or mid-word " cannot hide a trailing statement from the verb check
…le cannot escape the contained run directory
…eue/buffer/chunk sizes, command/idle timeouts) so a 0 cannot silently disable sessions or output
… so a bracket inside a # comment is not rejected as an exec
…l is not misreported dead, only ESRCH counts as gone
luarss
requested changes
Jun 27, 2026
…ry other domain model so snake_case is produced only by toSnakeCase at the wire boundary, not hand-written
…scated command like \socket or \x73ocket is matched as the command tcl actually runs, not the literal backslash form
…ituted command ($x or nested [[...]]) is surfaced and rejected by the read-only tool instead of running exec via runtime variable substitution
…rror message is inserted literally instead of being reinterpreted as a replacement pattern
luarss
merged commit 42f3652
into
The-OpenROAD-Project:feat/ts-migration
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full business logic layer is complete. This covers the PTY session management (spawning OpenROAD processes, reading output, handling termination), all 10 MCP tools with identical input/output schemas to the Python server, the command whitelist with security fixes that go beyond the Python baseline, report image listing and compression, settings, ANSI output cleaning, and path validation.
402 unit tests cover all of the above, plus an integration script that validates the full lifecycle against a real OpenROAD process.