Use yosys-slang from BCR#10766
Open
hzeller wants to merge 1 commit into
Open
Conversation
It had been added recently. https://registry.bazel.build/modules/yosys-slang Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the git override for the yosys-slang dependency in MODULE.bazel and replaces it with a direct bazel_dep declaration using version 0.0.0. The MODULE.bazel.lock file has been updated accordingly to reflect this dependency change and lock the new module. I have no feedback to provide on these changes.
Member
|
I believe this may be a concern due to the frequent updates. I'll let @povik decide if this makes sense. |
Contributor
|
This seems to be for the bazel-orfs flow sake to source the slang plugin for yosys, and not to replace the third-party/slang-elab submodule for syn, in which case it should be fine. The yosys plugin has been stable recently, the last update in ORFS is from 5 months ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It had been added recently.
https://registry.bazel.build/modules/yosys-slang