Update patch-apk.py#19
Open
Syth-1 wants to merge 2 commits into
Open
Conversation
fix: fixes a bug reading apktool from windows path leads to an error not found, added execute in shell with input '\n' to exit out of the apktool.bat wrapper, ensure we only read first line if available else give appropriate error.
Owner
|
Hi @Syth-1 ! This actually breaks the script on Linux, because you can't have shell=True and give a list of arguments on linux. The length check will also never be true because .split will return an array with one element (an empty string) which is >0. Can you try my fix to see if it works on Windows? |
Author
|
hi, thank you -- new changes worked perfectly on windows! forgot need to also do the same with sign_with_apksigner too as thats still throwing an error (made the changes locally, forgot to include it part of my patch) 🫠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: fixes a bug reading apktool from windows path leads to an error not found, added execute in shell with input '\n' to exit out of the apktool.bat wrapper, ensure we only read first line if available else give appropriate error.