Update docker to support API#536
Merged
Merged
Conversation
Use prebuilt image rather than building locally now that v4+ is pushed
Tidy up formatting
fixed another callout formatting
This pins the v4 version of the script to the 4 tag rather than latest
Update dockerfile and supporting scripts to support API mode in docker with scheduler
Contributor
Author
|
FYI I kept the lockfile behaviour for scheduled runs, with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates docker to support the new API mode. In short, with
API_MODE: trueset in the compose.yaml, the entrypoint starts API mode, then the scheduler acts on the API to invoke the script. API remains available while the container is up, and all API functions available (e.g., manually start, stop, etc.). All docker-based scheduling and +randomized time remain supported.If
API_MODE: falsethen falls back to old behaviour (i.e., cron invokes script directly, no API).Changes
Minor updates to the server.js so that API bot logs are written to stdout/stderr and visible to docker logs.
Updated:
Added: