fix: Windows-only encoder test pin missed in #151 (SoftwareOpenH264) - #152
Closed
TheOrcDev wants to merge 1 commit into
Closed
fix: Windows-only encoder test pin missed in #151 (SoftwareOpenH264)#152TheOrcDev wants to merge 1 commit into
TheOrcDev wants to merge 1 commit into
Conversation
…coder_args expects SoftwareOpenH264 The Windows CI gates on main fail since #151: bridge_recording_args_use_raw_yuv_video_and_existing_audio and shared_pipeline_uses_tee_for_dual_output assert the CURRENT platform's encoder, and their WindowsSoftware arm still pinned EncodeBackend::SoftwareMediaFoundation. That arm never executes on macOS, so the local suite stayed green while every Windows runner failed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Windows software H.264 encoder test expectation now uses ChangesWindows H.264 encoder
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows gates job on main has failed since #151 landed:
assert_current_h264_encoder_argsasserts against the current platform's encoder, and itsWindowsSoftwarearm still pinnedEncodeBackend::SoftwareMediaFoundationfrom before the libopenh264 switch. The arm is dead code on macOS, so the 1314-test local suite stayed green whilebridge_recording_args_use_raw_yuv_video_and_existing_audioandshared_pipeline_uses_tee_for_dual_outputfailed on every Windows runner.One-line pin update (+ comment). Local gates: full cargo suite green, clippy
-D warnings, fmt. The real proof is this PR's own Windows CI run — the gates job should go green again.🤖 Generated with Claude Code
Summary by CodeRabbit