Skip to content

fix: Windows-only encoder test pin missed in #151 (SoftwareOpenH264) - #152

Closed
TheOrcDev wants to merge 1 commit into
mainfrom
fix/windows-encoder-test-pin
Closed

fix: Windows-only encoder test pin missed in #151 (SoftwareOpenH264)#152
TheOrcDev wants to merge 1 commit into
mainfrom
fix/windows-encoder-test-pin

Conversation

@TheOrcDev

@TheOrcDev TheOrcDev commented Jul 17, 2026

Copy link
Copy Markdown
Owner

The Windows gates job on main has failed since #151 landed: assert_current_h264_encoder_args asserts against the current platform's encoder, and its WindowsSoftware arm still pinned EncodeBackend::SoftwareMediaFoundation from before the libopenh264 switch. The arm is dead code on macOS, so the 1314-test local suite stayed green while bridge_recording_args_use_raw_yuv_video_and_existing_audio and shared_pipeline_uses_tee_for_dual_output failed on every Windows runner.

One-line pin update (+ comment). Local gates: full cargo suite green, clippy -D warnings, fmt. The real proof is this PR's own Windows CI run — the gates job should go green again.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Updated Windows H.264 encoding validation to correctly recognize the OpenH264 software encoder.

…coder_args expects SoftwareOpenH264

The Windows CI gates on main fail since #151:
bridge_recording_args_use_raw_yuv_video_and_existing_audio and
shared_pipeline_uses_tee_for_dual_output assert the CURRENT platform's
encoder, and their WindowsSoftware arm still pinned
EncodeBackend::SoftwareMediaFoundation. That arm never executes on macOS,
so the local suite stayed green while every Windows runner failed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1964dd05-98a0-4963-adb5-4a4deddb41c6

📥 Commits

Reviewing files that changed from the base of the PR and between 8cf195a and d39fbfd.

📒 Files selected for processing (1)
  • crates/videorc-backend/src/recording.rs

📝 Walkthrough

Walkthrough

The Windows software H.264 encoder test expectation now uses EncodeBackend::SoftwareOpenH264 instead of SoftwareMediaFoundation.

Changes

Windows H.264 encoder

Layer / File(s) Summary
Update Windows encoder assertion
crates/videorc-backend/src/recording.rs
The test helper now expects the SoftwareOpenH264 backend for the Windows software encoder path and documents the fallback change.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: petercr

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the Windows encoder test expectation update to SoftwareOpenH264 and matches the main fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/windows-encoder-test-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TheOrcDev

Copy link
Copy Markdown
Owner Author

Superseded — main already carries this pin (fixed via #141/#154; recording.rs:13066 now asserts SoftwareOpenH264) and the latest main Windows run is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant