Unified Tooltip component for consolidating tooltip usage - #1484
Open
jabrailkhalil wants to merge 1 commit into
Open
jabrailkhalil wants to merge 1 commit into
jabrailkhalil wants to merge 1 commit into
Conversation
Add a styled Tooltip wrapper around corvu's tooltip to ui-components and use it in IconButton and the document picker, replacing direct corvu usage. The tooltip styling moves from icon_button.css into tooltip.css. Includes Storybook stories with interaction tests covering hover, focus, placement, custom triggers, and custom content classes.
Author
|
The CI workflows for the current head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1482
Consolidates the tooltip usage across CatColab into one unified
Tooltipcomponent inui-components.Changes
Tooltipcomponent wrapping corvu's tooltip, with the standardtooltip-contentstyling and options for placement, focus/hover behaviour, and custom content classes.IconButtonnow uses the unifiedTooltipinstead of embedding corvu directly (no behaviour change).icon_button.cssinto a dedicatedtooltip.css.Verification
pnpm --filter ./packages/ui-components test: 220/220 pass (including the 7 new Tooltip interaction tests, run headless in Chromium via vitest browser).ci(tcm, tsc, oxlint --deny-warnings, oxfmt --check, stylelint) clean; frontend oxlint/oxfmt/stylelint clean.storybook build); the UI Components preview will be deployed to Netlify.Follow-up candidates (kept out of this PR to keep it focused): the rich text editor's CSS
data-tooltipbuttons and remaining nativetitleattributes.