logger: retry transient Slack webhook failures#4957
Open
chrismaree wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
packages/logger/src/logger/SlackTransport.ts.429responses and common transient5xxstatuses before surfacing aTransportError.Retry-Afterheaders when present and caps the wait at 5 seconds to avoid long logger stalls.Retry-Aftercapping.Why
429to a normal monitor notification.TransportError, which can be routed into PagerDuty whenlogTransportErrorsis enabled.Impact
TransportErrorto the existing transport-error path.High risk Sections to review with detail
postWithRetryinSlackTransport.ts: retry count, retryable status list, and delay cap are the main behavior changes.getSlackPostRetryDelaySeconds: validates both numeric and date-formRetry-Afterheaders while bounding delay time.Validation
git diff --checkandgit diff --cached --checksuccessfully.packages/logger/test/logger/SlackTransport.retries.jscovering the intended retry behavior.Docs