fix: reset static fields for Fast Enter Play Mode#3956
Open
noellie-velez wants to merge 5 commits intodevelop-2.0.0from
Open
fix: reset static fields for Fast Enter Play Mode#3956noellie-velez wants to merge 5 commits intodevelop-2.0.0from
noellie-velez wants to merge 5 commits intodevelop-2.0.0from
Conversation
# Conflicts: # com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs
noellie-velez
commented
Apr 24, 2026
| } | ||
|
|
||
| internal static bool LogSerializationOrder = false; | ||
| internal static bool LogSerializationOrder; |
Collaborator
Author
There was a problem hiding this comment.
This is only used to perform some logging but it is never set to true and it is internal, should we keep it? Is this something that should go in the new logging system instead?
noellie-velez
commented
Apr 24, 2026
Comment on lines
3839
to
3849
| /// <inheritdoc/> | ||
| public override void OnLostOwnership() | ||
| { | ||
| base.OnLostOwnership(); | ||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public override void OnGainedOwnership() | ||
| { | ||
| base.OnGainedOwnership(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Why do we have these empty overrides? Do we need them?
noellie-velez
commented
Apr 24, 2026
| } | ||
|
|
||
| internal bool IsNested; | ||
| private List<NetworkObject> m_ParentedChildren = new List<NetworkObject>(); |
Collaborator
Author
There was a problem hiding this comment.
When is m_ParentedChildren updated? I had a warning about this in my IDE and didn't find the info myself 🫠
simon-lemay-unity
approved these changes
Apr 24, 2026
Contributor
simon-lemay-unity
left a comment
simon-lemay-unity
left a comment
There was a problem hiding this comment.
Changes to UnityTransport look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ensure com.unity.netcode.gameobjects package supports Fast Enter Play Mode
Jira ticket
MTT-14665
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
N/A