Skip to content

Add strict-kwargs pre-commit hook in fix mode#3172

Open
adamtheturtle wants to merge 9 commits into
mainfrom
chore/strict-kwargs-pre-commit
Open

Add strict-kwargs pre-commit hook in fix mode#3172
adamtheturtle wants to merge 9 commits into
mainfrom
chore/strict-kwargs-pre-commit

Conversation

@adamtheturtle
Copy link
Copy Markdown
Member

@adamtheturtle adamtheturtle commented May 18, 2026

Summary

  • Add the strict-kwargs pre-commit hook (rev: 2026.5.18) with args: [fix] so positional call arguments are rewritten to keyword form on commit.
  • Skip the hook in pre-commit CI (builds from source and needs a Rust toolchain).
  • Mirror [tool.mypy_strict_kwargs] into [tool.strict_kwargs] where custom ignore lists already exist.

Test plan

  • pre-commit run strict-kwargs --all-files

Note

Low Risk
Low risk: changes are limited to developer tooling (pre-commit configuration and a dev dependency) and do not affect runtime behavior.

Overview
Adds a new local pre-commit hook, strict-kwargs-fix, that runs strict-kwargs fix to automatically rewrite positional arguments into keyword arguments on commit.

Pins strict-kwargs in pyproject.toml dev dependencies and skips the new hook in pre-commit CI.

Reviewed by Cursor Bugbot for commit ab9f9bb. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread .pre-commit-config.yaml Outdated
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fc2ef96. Configure here.

Comment thread pyproject.toml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant