Skip to content

refactor: shared components to use Tailwind CSS - #5755

Open
therealemjy wants to merge 1 commit into
mainfrom
refactor/components-tailwind
Open

refactor: shared components to use Tailwind CSS#5755
therealemjy wants to merge 1 commit into
mainfrom
refactor/components-tailwind

Conversation

@therealemjy

Copy link
Copy Markdown
Member

Changes

  • refactor shared components to use Tailwind CSS

@therealemjy
therealemjy requested a review from cuzz-venus July 30, 2026 09:18
@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 433b3eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Jul 30, 2026 2:03pm
dapp-testnet Ready Ready Preview Jul 30, 2026 2:03pm
venus.io Ready Ready Preview Jul 30, 2026 2:03pm

Request Review

Comment thread apps/evm/src/components/Modal/index.tsx
@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown

Greptile Summary

The PR migrates shared EVM components from Emotion/MUI styling to Tailwind CSS.

  • Reimplements the shared modal with a native dialog and routes native cancellation through the controlled close callback.
  • Migrates checkbox, chips, progress indicators, pagination, token selection, toggles, and approval-step styling.
  • Expands component stories and updates modal-focused tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; native dialog cancellation now prevents the browser from independently closing the dialog and routes Escape through the parent-controlled close callback.

Important Files Changed

Filename Overview
apps/evm/src/components/Modal/index.tsx Replaces the MUI modal with a controlled native dialog; the prior Escape-state issue is resolved by preventing native cancellation and invoking handleClose.
apps/evm/src/components/Modal/tests/index.spec.tsx Adds coverage for backdrop and close-button callbacks, native cancellation routing, and child unmounting.
apps/evm/src/components/Checkbox/index.tsx Replaces the MUI checkbox with a styled native checkbox while preserving controlled input behavior.
apps/evm/src/components/Pagination/index.tsx Migrates pagination layout and controls to Tailwind-based shared buttons.
apps/evm/src/components/SelectTokenTextField/index.tsx Migrates token-selection field presentation to Tailwind CSS.
apps/evm/src/components/Toggle/index.tsx Reimplements toggle styling with Tailwind while retaining controlled interaction behavior.

Reviews (2): Last reviewed commit: "refactor: shared components to use Tailw..." | Re-trigger Greptile

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb9f8a5f6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/evm/src/components/Modal/index.tsx
Comment thread apps/evm/src/components/Modal/index.tsx
@therealemjy

Copy link
Copy Markdown
Member Author

@greptile

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 77.8% 49978 / 64235
🔵 Statements 77.8% 49978 / 64235
🔵 Functions 72.44% 1522 / 2101
🔵 Branches 85.07% 7304 / 8585
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/components/ActiveVotingProgress/index.tsx 98.07% 33.33% 100% 98.07% 107-108
apps/evm/src/components/ApprovalSteps/index.tsx 95.65% 80% 100% 95.65% 35-36
apps/evm/src/components/Checkbox/index.tsx 100% 75% 100% 100%
apps/evm/src/components/Chip/index.tsx 100% 100% 100% 100%
apps/evm/src/components/Chip/ActiveChip/index.tsx 100% 100% 0% 100%
apps/evm/src/components/Chip/BlueChip/index.tsx 100% 100% 0% 100%
apps/evm/src/components/Chip/Chip/index.tsx 100% 16.66% 100% 100%
apps/evm/src/components/Chip/ErrorChip/index.tsx 100% 100% 0% 100%
apps/evm/src/components/Chip/InactiveChip/index.tsx 66.66% 100% 0% 66.66% 5
apps/evm/src/components/Chip/ProposalTypeChip/index.tsx 40% 100% 0% 40% 8-15
apps/evm/src/components/Dropdown/index.tsx 66.66% 53.84% 20% 66.66% 46-49, 56-81
apps/evm/src/components/LabeledProgressBar/index.tsx 100% 100% 100% 100%
apps/evm/src/components/Modal/index.tsx 91.3% 83.33% 100% 91.3% 47-48, 51-53, 60-65
apps/evm/src/components/Modal/testIds.ts 100% 100% 100% 100%
apps/evm/src/components/Pagination/index.tsx 83.87% 85.71% 14.28% 83.87% 41-42, 72-77, 94-103
apps/evm/src/components/Pagination/PaginationButton/index.tsx 100% 100% 100% 100%
apps/evm/src/components/SelectTokenTextField/index.tsx 100% 100% 100% 100%
apps/evm/src/components/Toggle/index.tsx 100% 66.66% 75% 100%
Generated in workflow #13994 for commit 433b3eb by the Vitest Coverage Report Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant