fix(vtable): avoid loading lazy data in custom render sizing - #5266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n- Avoid eagerly reading body cell value/dataValue while computing customRender/customLayout auto size for lazy ListTable dataSource\n- Keep normal cell rendering behavior unchanged so visible cells can still use args.value\n- Add a regression test and debug demo for issue #4964\n\n## Why\nWhen ListTable uses a lazy dataSource without records, auto width/height computation may traverse many body cells. Passing args.value eagerly to customRender triggers dataSource.get for every visited row, causing the lazy data source to load far more records than needed.\n\n## Verification\n- npm test -- tests/options/listTable-custom-render-async-dataSource.test.ts --runInBand\n- npm run compile\n- git diff --check\n\nCloses #4964