Skip to content

reconnect functionality #11

Description

@youurayy

Sorry guys but the reconnect functionality is not ok.

  1. When voltdb goes away, the driver keeps calling the error callback once per second. (This in itself is a complete anti-pattern in Node.js, because once you return from a function with a success callback, you never return again either with success or error. This is just a broken design. You don't call return more than once.)
  2. When voltdb comes back, nothing happens, the error callback is still being called once per second.
  3. There's no way to handle this because the driver doesn't offer a close() functionality, so the only solution is to restart the Node.js process, which is lame.

Do you think you can fix this?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions