Skip to content

Avoid assertion in BrOn parsing#8635

Merged
kripken merged 1 commit intoWebAssembly:mainfrom
kripken:br_on.valid
Apr 21, 2026
Merged

Avoid assertion in BrOn parsing#8635
kripken merged 1 commit intoWebAssembly:mainfrom
kripken:br_on.valid

Conversation

@kripken
Copy link
Copy Markdown
Member

@kripken kripken commented Apr 21, 2026

The ref and the desc are used as references in finalize(), and we assert
there if they are e.g. i32.

Fixes #8633

@kripken kripken requested a review from a team as a code owner April 21, 2026 14:51
@kripken kripken requested review from tlively and removed request for a team April 21, 2026 14:51
@kripken kripken merged commit 1251efb into WebAssembly:main Apr 21, 2026
16 checks passed
@kripken kripken deleted the br_on.valid branch April 21, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion failure isRef() in wasm::Type::getHeapType() at wasm-type.h:407 (main branch @3ef8d19)

2 participants