Only analyze HTML belonging to the tested page#116
Merged
Conversation
A browsertime HAR can contain more than one page, for example when a concurrent browsertime run on the same host races for the same Chrome DevTools port and its crossed CDP session records another website's page load into this run's recording (see Webperf-se/webperf_core#1557). This analyzer took the first HTML response in the whole HAR as the page to search for an accessibility statement, so a crossed-in recording could make it search (and rate) another website's page. Filter entries to the ones belonging to the first page in the HAR's pages array, and verify that the recording's first request matches the tested URL's hostname (the URL API normalizes IDN hostnames to punycode on both sides). On mismatch nothing is analyzed and the existing no-network issue is reported. HARs without a pages array and entries without pageref behave as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a sweep across the HAR-consuming plugins; same problem class as Webperf-se/webperf_core#1557 / #1558, Webperf-se/plugin-pagenotfound#156, Webperf-se/plugin-css#159, Webperf-se/plugin-html#130, Webperf-se/plugin-javascript#130 and Webperf-se/plugin-standard-files#16.
Problem
Concurrent browsertime runs on one host can race for the same Chrome DevTools port; the crossed CDP session records the other run's page navigation into this run's HAR, so the HAR can contain more than one page.
transform2SimplifiedDatatook the first HTML response in the whole HAR as the page to search for an accessibility statement — with a crossed-in recording where the foreign page is recorded first, it would search and rate another website's page.Fix
New
getFirstPageEntries(url, harData):pagerefbelongs to the first page in the HAR'spagesarray;new URL(...)punycodes IDN hostnames on both sides) — on mismatch nothing is analyzed and the existingno-networkissue is reported instead of another website's data.The statement-hunting flow (following candidate links, each as its own
browsertime.harmessage) is unaffected since the check runs per message url. HARs without apagesarray and entries withoutpagerefbehave exactly as before.Validation
Synthetic crossed HARs, both directions: foreign-page-first yields the
no-networkpath instead of analyzing the wrong page; own-page-first analyzes only the tested page; legacy HAR withoutpagesunchanged;eslintclean.