Skip to content

test(eth): stabilize fast sync disabling test #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gzliudan merged 1 commit into from
Jun 21, 2026
Merged

test(eth): stabilize fast sync disabling test #2350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions eth/sync_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,13 @@ import (
func TestFastSyncDisabling(t *testing.T) {
// Create a pristine protocol manager, check that fast sync is left enabled
pmEmpty, _ := newTestProtocolManagerMust(t, downloader.FastSync, 0, nil, nil)
defer pmEmpty.Stop()
if atomic.LoadUint32(&pmEmpty.snapSync) == 0 {
t.Fatalf("snap sync disabled on pristine blockchain")
}
// Create a full protocol manager, check that snap sync gets disabled
pmFull, _ := newTestProtocolManagerMust(t, downloader.FastSync, 1024, nil, nil)
defer pmFull.Stop()
Comment on lines +34 to +40
if atomic.LoadUint32(&pmFull.snapSync) == 1 {
t.Fatalf("snap sync not disabled on non-empty blockchain")
}
Expand All @@ -45,11 +47,19 @@ func TestFastSyncDisabling(t *testing.T) {
go pmFull.handle(pmFull.newPeer(63, p2p.NewPeer(enode.ID{}, "empty", nil), io2))
go pmEmpty.handle(pmEmpty.newPeer(63, p2p.NewPeer(enode.ID{}, "full", nil), io1))

time.Sleep(250 * time.Millisecond)
pmEmpty.synchronise(pmEmpty.peers.BestPeer())
deadline := time.After(15 * time.Second)
ticker := time.NewTicker(100 * time.Millisecond)
defer ticker.Stop()

// Check that snap sync was disabled
if atomic.LoadUint32(&pmEmpty.snapSync) == 1 {
t.Fatalf("snap sync not disabled after successful synchronisation")
for {
if atomic.LoadUint32(&pmEmpty.snapSync) == 0 {
return
}
select {
case <-deadline:
t.Fatalf("snap sync not disabled after successful synchronisation")
case <-ticker.C:
pmEmpty.synchronise(pmEmpty.peers.BestPeer())
}
}
}
Loading