Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the triage automation script and documentation. The 'status: waiting-for-author-response' label logic has been modified to clear when any external contributor responds, rather than only the original author, while ignoring maintainer and bot replies. Additionally, P2 issues are no longer flagged for staleness, and the script now re-verifies that an issue is still open before applying label changes to handle lagging GitHub indices. Corresponding unit tests have been updated and added to cover these changes. There are no review comments, so I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
scripts/triage.mjsto match the specification in its header comment, and tightens the language of that specification.What changed in the spec
status: waiting-for-author-responseclears on a comment from any external contributor, not only from the item's author. Comments from the team never clear it — the team is the side that asked the question.Code
authorHasResponded(item, contributions, waitingSince)→externalHasResponded(contributions, waitingSince), which matches any non-maintainer, non-bot contribution at or after the labeling.itemis gone from the signature: authorship no longer factors into the rule.STALE_DAYSdrops itsP2: 90entry.docs/contributing/triage.mdstill described the old author-only rule, which contradicted the updated spec.Tests
node --test scripts/*.test.mjs— 58 tests, up from 51, all passing.externalHasResponded: a reply from an external contributor who is not the author clears the label; maintainer replies (OWNER/MEMBER/COLLABORATOR) and bot replies do not.STALE_DAYSkeys pinned toP0/P1, plus an explicit "never flags a P2, however old".Each clause of the new rule was mutation-tested: reverting the maintainer exclusion, the bot exclusion, the widening past the author, or the open-state guard fails exactly the test that pins it, and nothing else.