Skip to content

Format baseline sync files#130

Merged
aaditagrawal merged 1 commit into
mainfrom
sync/upstream-20260701-format-baseline
Jul 3, 2026
Merged

Format baseline sync files#130
aaditagrawal merged 1 commit into
mainfrom
sync/upstream-20260701-format-baseline

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jul 1, 2026

Copy link
Copy Markdown
Owner

What Changed

Formats the baseline sync files so the lower stack branch passes the project checks before the upstream sync slices land.

Why

This keeps the stack rooted on a clean formatting baseline and avoids mixing mechanical formatting with later behavioral sync work.

UI Changes

None.

Checklist

  • Part 1 of the upstream sync stack
  • Validation on stack tip: vp check
  • Validation on stack tip: vp run typecheck
  • Validation on stack tip: vp run lint:mobile
  • Full vp test had one ACP timeout flake; rerunning that file passed

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR makes two minor object-construction adjustments: GeminiCliServerManager instantiation in GeminiCliAdapter.ts uses a conditional object literal instead of conditional spread, and toUnifiedPatch in appSettings.ts spreads providersPatch[provider] directly without a nullish fallback.

Changes

Object construction cleanup

Layer / File(s) Summary
Conditional object literal simplification
apps/server/src/provider/Layers/GeminiCliAdapter.ts
Replaces conditional spread with a conditional object literal when constructing GeminiCliServerManager options.
Patch merge simplification
apps/web/src/appSettings.ts
Removes the nullish fallback when spreading providersPatch[provider] in toUnifiedPatch.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Related PRs: None identified.

Suggested labels: None

Suggested reviewers: None

🐰 Two tiny tweaks, spread just right,
No more fallback hiding out of sight,
Objects built with cleaner form,
Code review effort? Barely warm.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the PR’s broad goal of formatting baseline sync files and is related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description follows the required template and includes clear What Changed, Why, UI Changes, and Checklist sections.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/upstream-20260701-format-baseline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Jul 1, 2026
@github-actions github-actions Bot added the size:XS 0-9 effective changed lines (test files excluded in mixed PRs). label Jul 1, 2026
@aaditagrawal aaditagrawal marked this pull request as ready for review July 2, 2026 12:53
@aaditagrawal aaditagrawal merged commit fa5552a into main Jul 3, 2026
17 checks passed

Copy link
Copy Markdown
Owner Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant