fix: ignore parenthesis in value comments - #311
Merged
Conversation
KevSlashNull
force-pushed
the
kev-ignore-paren
branch
3 times, most recently
from
May 2, 2026 21:40
81a5e78 to
687944a
Compare
Owner
|
@KevSlashNull mind making sure the commits are verified? I think that's blocking me from approving the checks to run. |
This fixes a bug where the enum declaration parser respects closing
parenthesis (to close the `ENUM(` with a `)`) if they are in a value
comment.
For example, the following enum declaration parses incorrectly in
the latest version:
ENUM(
dog, // dog :)
cat, // cat :3
)
The resulting enum would only contain `dog` because the closing
parenthesis is considered to end the `ENUM` tag, which is incorrect.
This is fixed by ignoring the contents of value comments on a given line
(i.e. anything after `//` within the `ENUM(...)` declaration).
KevSlashNull
force-pushed
the
kev-ignore-paren
branch
from
July 9, 2026 12:48
2f80f49 to
a115a23
Compare
Contributor
Author
|
ahh i didn't notice that. thanks @abice, i signed the commit. |
|
coverage: 92.67% (+0.008%) from 92.662% — KevSlashNull:kev-ignore-paren into abice:master |
abice
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the enum declaration parser respects closing parenthesis (to close the
ENUM(with a)) if they are in a value comment.For example, the following enum declaration parses incorrectly in the latest version:
The resulting enum would only contain
dog(not because dogs are superior to cats, which they are, but) because the closing parenthesis is considered to end theENUMtag, which is incorrect.This is fixed by ignoring the contents of value comments on a given line (i.e. anything after
//within theENUM(...)declaration).