Skip to content

Keep path on breadcrumb segments so they render as links#25682

Merged
sumeyyeKurtulus merged 1 commit into
rel-10.5from
maliming/fix-breadcrumb-segment-path
Jun 25, 2026
Merged

Keep path on breadcrumb segments so they render as links#25682
sumeyyeKurtulus merged 1 commit into
rel-10.5from
maliming/fix-breadcrumb-segment-path

Conversation

@maliming

Copy link
Copy Markdown
Member

The breadcrumb built each segment with const { parent, children, isLeaf, path, ...segment } = node, dropping path from the rest, so breadcrumb-items always fell back to the non-link template. Kept path on the segment. Closes #22930

@maliming maliming added this to the 10.5-final milestone Jun 24, 2026
@maliming maliming requested a review from sumeyyeKurtulus June 24, 2026 02:13
@sumeyyeKurtulus sumeyyeKurtulus merged commit 202fdc1 into rel-10.5 Jun 25, 2026
1 of 3 checks passed
@sumeyyeKurtulus sumeyyeKurtulus deleted the maliming/fix-breadcrumb-segment-path branch June 25, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants