Angular - Enhancing MemoryTokenStorageService to support session storage for specific keys#25701
Merged
Conversation
…for specific keys
sumeyyeKurtulus
changed the title
MemoryTokenStorageService to support session storage for specific keysMemoryTokenStorageService to support session storage for specific keys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Angular MemoryTokenStorageService to reduce multi-tab interference during OIDC flows (notably in Chromium tab duplication/refresh scenarios), aligning with the reported logout behavior in #25663.
Changes:
- Routes selected OIDC transient keys (
nonce,PKCE_verifier,session_state) tosessionStorageinstead oflocalStorage. - Refactors
getItem/setItem/removeItembranching to support memory + session + local storage tiers. - Adds helper methods to safely access
sessionStorage.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fahrigedik
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #25663