Skip to content

Merge branch dev with rel-10.5#25741

Merged
voloagent merged 3 commits into
devfrom
auto-merge/rel-10-5/4691
Jul 3, 2026
Merged

Merge branch dev with rel-10.5#25741
voloagent merged 3 commits into
devfrom
auto-merge/rel-10-5/4691

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

This PR generated automatically to merge dev with rel-10.5. Please review the changed files before merging to prevent any errors that may occur.

maliming and others added 3 commits July 3, 2026 10:12
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…r-authenticated-client

Forward the current access token for authenticated client requests
@voloagent voloagent marked this pull request as ready for review July 3, 2026 05:47
Copilot AI review requested due to automatic review settings July 3, 2026 05:47
@voloagent voloagent merged commit a563a88 into dev Jul 3, 2026
1 check passed
@voloagent voloagent deleted the auto-merge/rel-10-5/4691 branch July 3, 2026 05:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This auto-generated merge brings in a behavioral fix (and accompanying tests) for HttpContextAbpAccessTokenProvider in the Volo.Abp.Http.Client.IdentityModel.Web package, ensuring access tokens can be forwarded for authenticated principals that may not represent an ABP “current user” (e.g., client_credentials flows).

Changes:

  • Updated HttpContextAbpAccessTokenProvider to rely on HttpContext.User.Identity.IsAuthenticated instead of ICurrentUser.IsAuthenticated.
  • Added a dedicated authentication handler used by tests to make an access_token retrievable via HttpContext.GetTokenAsync.
  • Added integration tests covering authenticated user, authenticated client without user id, and anonymous request scenarios.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
framework/test/Volo.Abp.Http.Client.IdentityModel.Web.Tests/Volo/Abp/Http/Client/IdentityModel/Web/TestTokenAuthHandler.cs Adds a test auth handler that injects an access_token into AuthenticationProperties for GetTokenAsync retrieval.
framework/test/Volo.Abp.Http.Client.IdentityModel.Web.Tests/Volo/Abp/Http/Client/IdentityModel/Web/HttpContextAbpAccessTokenProvider_Tests.cs Adds integration tests validating token forwarding behavior for authenticated user/client and not for anonymous requests.
framework/src/Volo.Abp.Http.Client.IdentityModel.Web/Volo/Abp/Http/Client/IdentityModel/Web/HttpContextAbpAccessTokenProvider.cs Adjusts the “authenticated” check to use HttpContext.User instead of ICurrentUser, enabling forwarding for authenticated non-user principals.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.87%. Comparing base (7ecb148) to head (24910c2).
⚠️ Report is 56 commits behind head on dev.

Files with missing lines Patch % Lines
...tityModel/Web/HttpContextAbpAccessTokenProvider.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #25741      +/-   ##
==========================================
+ Coverage   48.86%   48.87%   +0.01%     
==========================================
  Files        3733     3733              
  Lines      126277   126277              
  Branches     9709     9709              
==========================================
+ Hits        61707    61722      +15     
+ Misses      62726    62709      -17     
- Partials     1844     1846       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants