Make docs options floating button a real toggle for touch and keyboard#25748
Open
maliming wants to merge 2 commits into
Open
Make docs options floating button a real toggle for touch and keyboard#25748maliming wants to merge 2 commits into
maliming wants to merge 2 commits into
Conversation
- reveal on click (.is-open) instead of hover so touch devices can open it - hide the collapsed bar instantly to stop the translucent flash on scroll
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the docs “document options” UI so the collapsed (scrolled) options bar is controlled by a real button-based toggle rather than a hover-only pseudo-element, improving touch and keyboard usability and preventing a brief translucent flash during scroll collapse.
Changes:
- Replaces the collapsed bar’s
::beforehover button with an.options-header .toggle-btnFAB and.is-openstate styling. - Adds JS to toggle
.is-open, updatearia-expanded, close on outside click/Escape, and close when leaving the scrolled state. - Adds a new localized
DocumentOptionslabel across multiple languages and updates the Project document page markup to include the new header/body structure.
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.scss | Implements the new FAB + .is-open styling and collapse behavior in the SCSS source. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css | Updates the generated CSS to match the SCSS changes. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Scripts/vs.js | Adds click/tap + keyboard-based toggling and close behaviors for the collapsed options popover. |
| modules/docs/src/Volo.Docs.Web/Pages/Documents/Project/Index.cshtml | Adds .options-header + toggle button markup and wraps options in .options-body with an id for aria-controls. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/ar.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/cs.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/de.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/el.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/en.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/en-GB.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/es.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/fi.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/fr.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/hi.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/hr.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/hu.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/is.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/it.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/nl.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/pl-PL.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/pt-BR.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/ro-RO.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/ru.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/sk.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/sl.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/sv.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/tr.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/vi.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/zh-Hans.json | Adds DocumentOptions localization. |
| modules/docs/src/Volo.Docs.Domain/Volo/Docs/Localization/Domain/zh-Hant.json | Adds DocumentOptions localization. |
Files not reviewed (1)
- modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.css: Generated file
Comments suppressed due to low confidence (1)
modules/docs/src/Volo.Docs.Web/Pages/Documents/Shared/Styles/vs.scss:180
p.alert-pis now always hidden in thebody.scrolledMore .alert-criteriapopover because the selector only checks for.options-header. Since this PR adds.options-headerto module pages too, the "MultipleVersionDocumentInfo" line will never appear while scrolled, contradicting the comment that module pages keep it.
// abp.io renders an .options-header title, so its info line is redundant; module pages keep it
&:has(.options-header) p.alert-p {
display: none !important;
}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #25748 +/- ##
==========================================
+ Coverage 48.84% 48.87% +0.02%
==========================================
Files 3733 3733
Lines 126277 126280 +3
Branches 9709 9710 +1
==========================================
+ Hits 61682 61715 +33
+ Misses 62764 62728 -36
- Partials 1831 1837 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- add a :focus-visible ring on the toggle button for keyboard users - keep the info line visible in the popover - namespace and unbind the toggle handlers to avoid stacking on re-init
salihozkara
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hover-only
::beforeball for the scrolled document-options bar with a real.toggle-btnthat opens the popover on click, so it works on touch and keyboard, and hide the collapsed bar instantly to stop the translucent flash while scrolling.