Skip to content

Fix resource lookup error in createLocalizer#25750

Draft
chandralk wants to merge 2 commits into
abpframework:devfrom
chandralk:patch-2
Draft

Fix resource lookup error in createLocalizer#25750
chandralk wants to merge 2 commits into
abpframework:devfrom
chandralk:patch-2

Conversation

@chandralk

Copy link
Copy Markdown
Contributor

Description

Resolves #25749 (write the related issue number if available)

The createLocalizer function is trying to look up in localization.values object instead of localization.resources object while trying to match the resource name. Fixed the same.

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

@chandralk chandralk marked this pull request as draft July 4, 2026 14:03
@chandralk

Copy link
Copy Markdown
Contributor Author

It seems the behaviour of localization is different between the data table header and the form label. I'll check it thoroughly and re-raise the PR.

@chandralk

Copy link
Copy Markdown
Contributor Author

Even after fixing the above, I am facing other problems. Specifically with this line:

Here, the displayName parameter would already be fully qualified i.e. it will be in the form on Resource::Key. But it seems that if it is an extra property, we are again prefixing it with ::. This ultimately is resulting in the ignoring the Key and only the Resource name is being returned.

I don't know at which level this needs to be addressed.

Requesting help from maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Localization doesn't work properly for extended properties in Angular

1 participant