feat: v5 + Spoke#1481
Open
grasphoper wants to merge 8 commits into
Open
Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
* feat: SpokePool V5 fill Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * add gateway param to all contracts Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * address feedback Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * require gateway Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * update deploy scripts Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * add _fillRelayV5 Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * faactor out _recordFill Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * refactor _transferTokensToRecipient Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * update comments Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * add executeAcrossV5 call Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * add nonV5Fill guard to rest of functions Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * check for msg.value Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * missing error Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * tests Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * return outputToken and recipientToSend from _transferTokensToRecipient Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * check relayer provided message Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * udpate var naming Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * update _fillRelayV5 param names Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * add nonReentrant Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> --------- Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
* init commit: SpokePool as v5 adapter for deposits Signed-off-by: Ihor Farion <ihor@umaproject.org> * impl _resolveDynamicParams Signed-off-by: Ihor Farion <ihor@umaproject.org> * change constructors of all Spokes Signed-off-by: Ihor Farion <ihor@umaproject.org> * bind to pathId instead Signed-off-by: Ihor Farion <ihor@umaproject.org> * improve comments, remove one static call Signed-off-by: Ihor Farion <ihor@umaproject.org> * move things around a bit Signed-off-by: Ihor Farion <ihor@umaproject.org> * only active v5 flow Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove comment Signed-off-by: Ihor Farion <ihor@umaproject.org> * fix after-merge build + move structs Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Ihor Farion <ihor@umaproject.org>
* feat: SpokePool fill as adapter Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * udpate struct names Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * restructure the functions Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> * reduce natspec length Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com> --------- Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
* update Spoke to match new fill logic Signed-off-by: Ihor Farion <ihor@umaproject.org> * adjust tests Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Ihor Farion <ihor@umaproject.org>
grasphoper
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
* foundry profile and sizes Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove spoke-as-adapter functionality Signed-off-by: Ihor Farion <ihor@umaproject.org> * remove size snapshots Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Ihor Farion <ihor@umaproject.org>
mrice32
reviewed
Jul 3, 2026
|
|
||
| V3RelayData memory relayData = V3RelayData({ | ||
| depositor: fillJit.depositor, | ||
| recipient: fillInput.recipient, |
Contributor
There was a problem hiding this comment.
Why is the recipient and outputToken an input, while other fields are JIT? Not saying that's wrong, just trying to understand the reasoning.
Collaborator
Author
There was a problem hiding this comment.
user's money is tied to the witness, which in turn gets constructed (waves hands) from input
- input.recipient makes sure that when a
pathIdis emitted => the funds went to the user (same as havingTRANSFERcmd in the general tape) - input.token + input.minAmount makes sure that no one can spam-create
pathIdfrom a user order without first spending at leastminAmount(this acts as a sort ofBALANCE_REQ)
So these two make spoke-as-executor similar to:
[BALANCE_REQ, TRANSFER(recipient), optional-handleV3]
Let's say we didn't commit to input.recipient:
- pathId could be emitted for an unrelated fill that spammer would just send to self
If we didn't commit to token, minAmount:
- pathId could be emitted with 1 wei
Also, take another tape:
[ADAPTER_CALL, TRANSFER-or-actions-from-input]
ADAPTER_CALL gets BALANCE_REQ included in it basically for free, giving us the same pathId guarantees as in the spoke-as-executor case.
If we didn't have these, we'd have to have a BALANCE_REQ in this flow. (just in the spirit of making simple flows more lean)
Contributor
There was a problem hiding this comment.
Makes sense. The minAmount ties it together. I missed that in my review.
| inputToken: fillJit.inputToken, | ||
| outputToken: fillInput.outputToken, | ||
| inputAmount: fillJit.inputAmount, | ||
| outputAmount: fillJit.outputAmount, |
Contributor
There was a problem hiding this comment.
Any concerns around the case where someone sends an invalid fill (0 output amount), but the indexer thinks this is complete because the rest of the actions don't care about the output amount of the fill?
Collaborator
Author
There was a problem hiding this comment.
That's what minAmount protection gives us (see above). Even if minAmount is static (e.g. with 5% slippage), whereas fill.outputAmount is dynamic, noone can "just emit a pathId for free"
Contributor
There was a problem hiding this comment.
Makes sense. I missed that.
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Ihor Farion <ihor@umaproject.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.