Conversation
lorennorman
approved these changes
Nov 10, 2023
Contributor
lorennorman
left a comment
lorennorman
left a comment
There was a problem hiding this comment.
This is all just really great! I had lots of notes reading through this but overall it's an obviously-better direction, better organized, more bang-for-buck, easier and more performant to implement in code.
PetteriAimonen
left a comment
PetteriAimonen
left a comment
There was a problem hiding this comment.
Overall, looks reasonable. I'd consider removing the deprecated fields completely at this point, as you are making such large API changes that no existing code will be compatible anyway.
This was referenced Feb 28, 2024
… I2cDeviceDescriptor
Remove predefined bus, support N I2C buses
Refactor around gps.proto
GPS - Small Fixes
V2 displays plus i2c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WipperSnapper API V2 aims to address:
signalsensor.protopin.protointoanalogio.protoandanalogio.proto