fix: correct errors in docs#322
Open
Mesut Oezdil (mesutoezdil) wants to merge 7 commits into
Open
Conversation
Mesut Oezdil (mesutoezdil)
added a commit
to mesutoezdil/substrate
that referenced
this pull request
Jun 27, 2026
Reverts the Contributor Covenant version bump (1.4 -> 2.1) per maintainer request in PR agent-substrate#322.
Mesut Oezdil (mesutoezdil)
added a commit
to mesutoezdil/substrate
that referenced
this pull request
Jul 9, 2026
Reverts the Contributor Covenant version bump (1.4 -> 2.1) per maintainer request in PR agent-substrate#322.
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/doc-errors
branch
from
July 9, 2026 16:55
226db06 to
701341d
Compare
Mesut Oezdil (mesutoezdil)
added a commit
to mesutoezdil/substrate
that referenced
this pull request
Jul 14, 2026
Reverts the Contributor Covenant version bump (1.4 -> 2.1) per maintainer request in PR agent-substrate#322.
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/doc-errors
branch
3 times, most recently
from
July 15, 2026 20:41
5050678 to
3cafa77
Compare
…alkey command Actor-centric log query used ate.dev/actor_id, actual label is ate.dev/actor_name.
Mesut Oezdil (mesutoezdil)
force-pushed
the
fix/doc-errors
branch
from
July 16, 2026 06:43
3cafa77 to
a1de546
Compare
# Conflicts: # docs/observability.md
Contributor
Author
|
Haven Xia (@HavenXia) Another small docs fix, a quick look would be appreciated. |
Haven Xia (HavenXia)
requested changes
Jul 22, 2026
|
|
||
| To make underlying infrastructure transitions transparent, Agent Substrate establishes a standardized metadata model to identify actors across worker pods: | ||
| * `ate.dev/actor_name`: The name of the actor (e.g., `my-counter-1` or `test`). | ||
| * `ate.dev/actor_id`: The unique identifier of the actor (e.g., `my-counter-1` or `test`). |
Collaborator
There was a problem hiding this comment.
This line is correct at main, actor_name is the correct use now.
|
|
||
| ```bash | ||
| kubectl ate logs actors <actor-name> [--follow / -f] | ||
| kubectl ate logs actors <actor_id> [--follow / -f] |
Collaborator
There was a problem hiding this comment.
same as my another comment.
Contributor
Author
There was a problem hiding this comment.
done
| kubectl ate get actor -A --trace | ||
| # or | ||
| kubectl ate suspend actor <actor-name> -a <atespace> --trace | ||
| kubectl ate suspend actor <actor-id> -a <atespace> --trace |
Collaborator
There was a problem hiding this comment.
same as my another comment.
Contributor
Author
There was a problem hiding this comment.
done
Revert actor_id/actor_uid regression in observability.md per review. Merge fixes from agent-substrate#349, agent-substrate#359, agent-substrate#323 into this PR.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/observability.md: log label keys were wrong. The code emitsate.dev/actor_idandate.dev/actor_template_name; the doc hadactor_idandactor_template. The Cloud Logging queries would return no results.docs/dev/best-practices/tracing.md: container ports entry used Docker Compose syntax ("443:443"). Changed tocontainerPort: 443.docs/dev/valkey-direct-access.md: thekubectl execcommand had a line break inside--cert, making it fail on copy-paste.code-of-conduct.md: linked to Contributor Covenant v1.4. Updated to v2.1.