fix: ignore empty node-name entries in resume locality restriction#452
Closed
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Closed
Conversation
Heals actor records poisoned before the pause-finalization fix, where an unknown node name was written as [""] in NodeVmsWithLocalSnapshots and permanently blocked resume. Fixes agent-substrate#397
Contributor
Author
|
Dmitry Berkovich (@dberkov) could you take a look when you have a moment, this is the read-side follow-up to #397 we discussed on #329? |
Contributor
Author
|
Closing in favor of #399, which covers the same read-side fix and was opened first (2026-07-06). Thanks for catching this. |
Mesut Oezdil (mesutoezdil)
deleted the
fix/resume-ignore-empty-node-restriction
branch
July 17, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findFreeWorker now ignores empty entries in the node restriction list, so actor records poisoned before #329 (unknown node written as
[""]) heal on the next resume instead of staying stuck forever. Real restrictions are unaffected.This is the read-side half of #397's proposed fix. The write-side half landed in #329, but as a CRASHED status instead of the unrestricted-placement approach #397 originally proposed (per review discussion there), so leaving this as a reference rather than auto-closing.
Test plan:
go build ./...,go test ./cmd/ateapi/..., extendedTestFindFreeWorker_EmptyNodeRestriction.Relates to #397