Skip to content

Guard the firebase-tools version-check message against drifting from the enforced minimum #3703

Description

@armando-navarro

Background

src/schematics/firebaseTools.ts enforces a minimum firebase-tools version and prints an error when it isn't met. The enforced version and the message are two separate string literals:

if (semverCompare(version, '14.0.0') === -1) {
    console.error('firebase-tools version 14.0.0+ is required, please upgrade and run again');

These drifted once: when the check was raised from 13 to 14 (v20 release prep, c1c6af9), the message kept saying "13.0.0+" until it was corrected in #3662.

Proposal

Derive both from a single minFirebaseToolsVersion constant so they can't disagree again. No behavior change.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Fixed!Resolved in a current release.comp: schematicsng add / deploy schematics (src/schematics).type: choreMaintenance with no user-facing behavior change.version: current (v17+)Targets the current modular API (v17+).

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions