fix(material/menu): missing panelClass getter#33191
Merged
ok7sai merged 1 commit intoangular:mainfrom May 3, 2026
Merged
Conversation
crisbeto
reviewed
May 3, 2026
| * @param classes list of class names | ||
| */ | ||
| @Input('class') | ||
| get panelClass(): string { |
Member
There was a problem hiding this comment.
Is there context behind this change? I don't feel strongly against it, it's just been like that for a long time and it never came up.
Member
Author
There was a problem hiding this comment.
There's an internal design system tries to override the menu style with a directive that does something like
this.matMenu.panelClass = `${this.matMenu.panelClass} new-theme`;
Which is not working currently because without a getter this.matMenu.panelClass always return undefined.
The above code exists today while it doesn't work. It's not raised up probably because 1) the directive is newly added and 2) there's no panelClass usage along with the directive yet... until now that I am using it.
crisbeto
approved these changes
May 3, 2026
ok7sai
added
action: merge
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.